Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.sdl2: test-suite needs x server, so deactivate it #49674

Merged
merged 1 commit into from Nov 3, 2018

Conversation

typetetris
Copy link
Contributor

Motivation for this change

haskellPackages.sdl2 has a test-suite sdl-space, which needs an x server and can't be run
in the build environment. so lets deactivate it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@typetetris
Copy link
Contributor Author

fixes #46130

@peti peti merged commit 1cd1a34 into NixOS:master Nov 3, 2018
@typetetris typetetris deleted the fix-46130 branch November 3, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants