Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-asm: fix build on macOS Mojave #49673

Merged
merged 1 commit into from Nov 3, 2018
Merged

cargo-asm: fix build on macOS Mojave #49673

merged 1 commit into from Nov 3, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 3, 2018 •
edited

Motivation for this change

Building cargo-asm on Mojave fails with

ld: framework not found Security

Add Security as a build input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
cargo-asm: fix build on macOS Mojave
1f21fc5 
Building cargo-asm on Mojave fails with

ld: framework not found Security

Add Security as a build input.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-asm

Partial log (click to expand)

these paths will be fetched (0.61 MiB download, 3.53 MiB unpacked):
  /nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16
copying path '/nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16' from 'https://cache.nixos.org'...
/nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16

@dywedir
Copy link
Member

dywedir commented Nov 3, 2018

@GrahamcOfBorg build cargo-asm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-asm

Partial log (click to expand)

these paths will be fetched (0.61 MiB download, 3.53 MiB unpacked):
  /nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16
copying path '/nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16' from 'https://cache.nixos.org'...
/nix/store/pym1p0nd7b5vxcgl216f8pckc4ai4i2z-cargo-asm-0.1.16

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cargo-asm

Partial log (click to expand)

   Compiling serde_derive v1.0.66
   Compiling structopt v0.2.10
   Compiling cargo-asm v0.1.16 (/private/tmp/nix-build-cargo-asm-0.1.16.drv-0/source)
    Finished release [optimized] target(s) in 48.97s
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/m0qqg52rlc1yp216p77gdsx8ppp65wd1-cargo-asm-0.1.16/bin
patching script interpreter paths in /nix/store/m0qqg52rlc1yp216p77gdsx8ppp65wd1-cargo-asm-0.1.16
/nix/store/m0qqg52rlc1yp216p77gdsx8ppp65wd1-cargo-asm-0.1.16

@dywedir dywedir merged commit 6742bdc into NixOS:master Nov 3, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-asm

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16
shrinking /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16/bin/cargo-asm
shrinking /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16/bin/cargo-llvm-ir
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16/bin
patching script interpreter paths in /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16
checking for references to /build in /nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16...
/nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-asm

Partial log (click to expand)

these derivations will be built:
  /nix/store/3s2n2likc0yvhzqq3fj5n7mhwbrcb640-rustc-1.30.0.drv
  /nix/store/mxgv178gszfczmkcrrxrdlmxm2wfhssc-cargo-1.30.0.drv
  /nix/store/v3ssn5gpmslpakrczln4j7pwfmrqxlnw-cargo-asm-0.1.16.drv
waiting for locks or build slots...
/nix/store/0pihpzlrh1wj4kgk5kb9i2fpz93i9ysr-cargo-asm-0.1.16

@danieldk danieldk deleted the cargo-asm-security branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @GrahamcOfBorg @dywedir