Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folly: 2018.08.27.00 -> 2018.10.29.00 #49656

Merged
merged 1 commit into from Nov 3, 2018
Merged

folly: 2018.08.27.00 -> 2018.10.29.00 #49656

merged 1 commit into from Nov 3, 2018

Conversation

langston-barrett
Copy link
Contributor

Folly disabled autotools-based builds in favor of CMake.

Motivation for this change

Package upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@langston-barrett
folly: 2018.08.27.00 -> 2018.10.29.00
45db416 
Folly disabled autotools-based builds in favor of CMake.
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

@GrahamcOfBorg build folly

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: folly

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: folly

Partial log (click to expand)

-- Installing: /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00/lib/cmake/folly/folly-targets.cmake
-- Installing: /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00/lib/cmake/folly/folly-targets-release.cmake
-- Installing: /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00/lib/pkgconfig/libfolly.pc
-- Installing: /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00/lib/libfollybenchmark.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00/lib
patching script interpreter paths in /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00
checking for references to /build in /nix/store/zvwrbs0vg2vd7p2zmgvlwcqv2j4qdpw8-folly-2018.10.29.00...

@c0bw3b c0bw3b merged commit 8b54203 into NixOS:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@langston-barrett @c0bw3b @GrahamcOfBorg