Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop old ghc versions 7.10.3, 8.0.2, and 8.4.3. #49653

Merged
merged 2 commits into from Nov 3, 2018

Conversation

peti
Copy link
Member

@peti peti commented Nov 2, 2018

We keep the latest minor release of each one of the last 3 major releases, which currently are GHC versions 8.2.2, 8.4.4, and 8.6.1. We also have ghc-HEAD, but this doesn't count.

Dropping these compilers implied that we have to drop the corresponding versions of ghcjs, too. We can also drop a shitload of obsolete compiler patches that newer versions no longer need.

At some point, we can probably simplify the generic builder, too.

We keep the latest minor release of each one of the last 3 major releases,
which currently are GHC versions 8.2.2, 8.4.4, and 8.6.1. We also have
ghc-HEAD, but this doesn't count.

Dropping these compilers implied that we have to drop the corresponding
versions of ghcjs, too. We can also drop a shitload of obsolete compiler
patches that newer versions no longer need.

At some point, we can probably simplify the generic builder, too.
Just use whatever is the current default.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zsh-git-prompt

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nsdvild1n39zlx09mczq0i5vxbd3b92g-zsh-git-prompt-0.5/lib
patching script interpreter paths in /nix/store/nsdvild1n39zlx09mczq0i5vxbd3b92g-zsh-git-prompt-0.5
checking for references to /build in /nix/store/nsdvild1n39zlx09mczq0i5vxbd3b92g-zsh-git-prompt-0.5...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/w9rvygqvnixz5j19j09slk9dhyfj9yp9-zsh-git-prompt-0.5-doc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w9rvygqvnixz5j19j09slk9dhyfj9yp9-zsh-git-prompt-0.5-doc
checking for references to /build in /nix/store/w9rvygqvnixz5j19j09slk9dhyfj9yp9-zsh-git-prompt-0.5-doc...
/nix/store/nsdvild1n39zlx09mczq0i5vxbd3b92g-zsh-git-prompt-0.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: zsh-git-prompt

Partial log (click to expand)

Registering library for git-prompt-0.1.0.0..
post-installation fixup
Moving /nix/store/wqicszpx76y8c756m9sf0g9m5sap49zw-zsh-git-prompt-0.5/share/doc to /nix/store/vqi4l71iwj6r2f3aq48ryizr51pj095l-zsh-git-prompt-0.5-doc/share/doc
rmdir: failed to remove '/nix/store/wqicszpx76y8c756m9sf0g9m5sap49zw-zsh-git-prompt-0.5/share': Directory not empty
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wqicszpx76y8c756m9sf0g9m5sap49zw-zsh-git-prompt-0.5/lib
patching script interpreter paths in /nix/store/wqicszpx76y8c756m9sf0g9m5sap49zw-zsh-git-prompt-0.5
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/vqi4l71iwj6r2f3aq48ryizr51pj095l-zsh-git-prompt-0.5-doc
/nix/store/wqicszpx76y8c756m9sf0g9m5sap49zw-zsh-git-prompt-0.5

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: zsh-git-prompt

Partial log (click to expand)

cannot build derivation '/nix/store/s0ljskp9nw3l4b2il6gjm8blhdskr11w-hscolour-1.24.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ab9c3j25syq0g551m6cjhi39w83qh5xy-nanospec-0.2.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7mh0y4x0x0z1bl18wzjvkz2xg6zdcs37-primitive-0.6.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/fvy41km16rccy44rl39280z0jp2zxrnc-random-1.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0bqpk2280y7czaxwql14zaplqxri10pw-call-stack-0.1.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ain8612klyii3zpppbnksmmanmwbb8vm-tf-random-0.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0v2qnm9cf5ayhj0f42n8l7slz0bvd0il-HUnit-1.6.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/1l338sfr0iabmra6wkmmx78ys42n6xx9-QuickCheck-2.11.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/4sazwiapc3yg9cjsd55sv8y5sbxk1hdb-zsh-git-prompt-0.5.drv': 3 dependencies couldn't be built
error: build of '/nix/store/4sazwiapc3yg9cjsd55sv8y5sbxk1hdb-zsh-git-prompt-0.5.drv' failed

@peti peti merged commit bf084e0 into NixOS:master Nov 3, 2018
Picking up garbage automation moved this from In progress to Done Nov 3, 2018
@peti peti deleted the drop-old-ghc-versions branch November 3, 2018 18:44
@Ericson2314
Copy link
Member

Can't ghc7103Binary also be dropped?

@peti
Copy link
Member Author

peti commented Nov 6, 2018

Yes, good point. I thought it would still be needed for some reason, but I was mistaken. I've removed it in aa15cce.

@Ericson2314
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants