Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide all the binaries needed by the vim-go plugin #49669

Merged
merged 18 commits into from Nov 4, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 3, 2018

Motivation for this change

The vim-go plugin requires some external binaries to function properly, this change patches the plugin with the PATH that provides all the binaries it needs.

I tested the plugin with:

nix-shell -I nixpkgs=. --pure -p 'with import <nixpkgs> {}; neovim.override { configure = { vam.pluginDictionaries = [ "vim-go" ]; }; }'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

replaces #49498

@kalbasit
Copy link
Member Author

kalbasit commented Nov 3, 2018

not sure if this works, I'll try anyway

@GrahamcOfBorg build -E 'with import {}; neovim.override { configure = { vam.pluginDictionaries = [ "vim-go" ]; }; }'

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: -E, 'with, import, , {};, neovim.override, {, configure, =, {, vam.pluginDictionaries, =, [, "vim-go", ];, };, }'

Partial log (click to expand)


Cannot nix-instantiate `];' because:
error: attribute '];' in selection path '];' not found

Cannot nix-instantiate `};' because:
error: attribute '};' in selection path '};' not found

Cannot nix-instantiate `}'' because:
error: attribute '}'' in selection path '}'' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: -E, 'with, import, , {};, neovim.override, {, configure, =, {, vam.pluginDictionaries, =, [, "vim-go", ];, };, }'

Partial log (click to expand)


Cannot nix-instantiate `];' because:
error: attribute '];' in selection path '];' not found

Cannot nix-instantiate `};' because:
error: attribute '};' in selection path '};' not found

Cannot nix-instantiate `}'' because:
error: attribute '}'' in selection path '}'' not found

kalbasit referenced this pull request Nov 3, 2018
aarch64 cpus are going to break on pkgsi686Linux packages.

See this error:

https://hydra.nixos.org/build/82962379/
@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@@ -9,6 +9,12 @@
, languagetool
, Cocoa, CoreFoundation, CoreServices
, buildVimPluginFrom2Nix

# vim-go denpencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# vim-go denpencies
# vim-go dependencies

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018

@GrahamcOfBorg build asmfmt deadcode errcheck go-check go-tools goconst gocyclo gogetdoc gometalinter gosec iferr impl ineffassign interfacer maligned reftools unconvert vimPlugins.vim-go

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert, vimPlugins.vim-go

Partial log (click to expand)

/nix/store/q7dx24481vanmh8mw8aaclfvnj28fxxv-gometalinter-2.0.11-bin
/nix/store/6ga4s4vxg7ns14s2gfhmpmlr99hak8qy-gosec-1.1.0-bin
/nix/store/0paz426p9jnmlgbsl2lqy1l6sdkc34ws-iferr-unstable-2018-06-15-bin
/nix/store/cc63rixcsyisvm8gmnqg7cqs9avnynwi-impl-unstable-2018-02-27-bin
/nix/store/ks9w7hx7gxhfdak33qi6dv826xb111jd-ineffassign-unstable-2018-09-09-bin
/nix/store/8n4fkrk4imrfgn56rw1nkb8pqmaq8rkn-interfacer-unstable-2018-08-31-bin
/nix/store/lc5vlna36dxrq93pr6pvprywfb8rf0zr-maligned-unstable-2018-07-07-bin
/nix/store/zyrhw9gmcfg3pbdfk8s423a9y524wr72-reftools-unstable-2018-09-14-bin
/nix/store/a3vsyqys55vrx0lkcdz82v8r0qfza091-unconvert-unstable-2018-07-03-bin
/nix/store/j1pzmwkw5cb9ps6w0mvlfrzfsyh3wmxy-vimplugin-vim-go-2018-10-23

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert, vimPlugins.vim-go

Partial log (click to expand)

/nix/store/bxc8rgn3yh560zfakhf1nnmcv22i5yx1-gometalinter-2.0.11-bin
/nix/store/l2xa17z1dsbyqidhyd6dm3gpdswj87vl-gosec-1.1.0-bin
/nix/store/rdik315xpy4xk7w265yxzribznrk7ca8-iferr-unstable-2018-06-15-bin
/nix/store/l9986i22zc17dg86a0ykpkvpp056ahrl-impl-unstable-2018-02-27-bin
/nix/store/f71m2hrs3l7m4aikw009cvnsmzdz5ask-ineffassign-unstable-2018-09-09-bin
/nix/store/9ci2mkqa6cw6qgi0zvg722dij3dax71h-interfacer-unstable-2018-08-31-bin
/nix/store/kgxybca667fnaxm8bfd3qlr0njy94ddp-maligned-unstable-2018-07-07-bin
/nix/store/wgl0pchl0l6hyshxrlrgj3kllglh4wf9-reftools-unstable-2018-09-14-bin
/nix/store/g0c6a18xjy00fs6vgsgj3dh01biviyhf-unconvert-unstable-2018-07-03-bin
/nix/store/26b596vmmlfg5d43skb7vq83393ycm5z-vimplugin-vim-go-2018-10-23

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert

The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins.vim-go

Partial log (click to expand)

/nix/store/8dvmf8l5xrs820r6fplg44qxqx82aib3-gogetdoc-unstable-2018-10-25-bin
/nix/store/r897rapc6mlrq3x40p85l9gl1jp0nak8-gometalinter-2.0.11-bin
/nix/store/dwdkmwi09lj5glxh5ig1xxp3kaqyrhjm-gosec-1.1.0-bin
/nix/store/qmb1pvcil1qp9njq4xf76df27z9wldzm-iferr-unstable-2018-06-15-bin
/nix/store/zzh7a3dqp6lrkg9hk7gjkksq3vydkdha-impl-unstable-2018-02-27-bin
/nix/store/44fqwaw5zc4h2hlc8dg9317c07gmwxrw-ineffassign-unstable-2018-09-09-bin
/nix/store/pwn87nfqwn3ym88f9ax2ynddg1gd3b7v-interfacer-unstable-2018-08-31-bin
/nix/store/sd7wd68iipdaxdz0zlqqli9x54v80pcy-maligned-unstable-2018-07-07-bin
/nix/store/yj4yj1clms0vdp7rf7v183dbmk4j0xhk-reftools-unstable-2018-09-14-bin
/nix/store/fxq0mvlk87j3ibsvfhjfl2hl2jjdcajg-unconvert-unstable-2018-07-03-bin

@Mic92 Mic92 merged commit 2a3aa76 into NixOS:master Nov 4, 2018
@kalbasit kalbasit deleted the nixpkgs_provide-binaries-for-vim-go branch May 18, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants