Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 11.4.3 -> 11.4.4 #49663

Merged
merged 1 commit into from Nov 3, 2018
Merged

gitlab: 11.4.3 -> 11.4.4 #49663

merged 1 commit into from Nov 3, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 3, 2018

Motivation for this change

The GitLab Kubernetes integration was vulnerable to a SSRF issue which could allow an attacker to make requests to access any internal URLs. The issue is now mitigated in the latest release and is assigned CVE-2018-18843.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @globin @fpletz

We should backport to 18.09 and 18.03 as well.

@flokli
gitlab: 11.4.3 -> 11.4.4
9e491f7 
SSRF in Kubernetes integration
The GitLab Kubernetes integration was vulnerable to a SSRF issue which could allow an attacker to make requests to access any internal URLs. The issue is now mitigated in the latest release and is assigned CVE-2018-18843.
@flokli
Copy link
Contributor Author

flokli commented Nov 3, 2018

@GrahamcOfBorg test gitlab

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/77x472py3p9raph3zimy8lssin7jdyjz-gitlab-11.4.4

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gitlab

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/rspec-stackprof: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/nbaqxqngzm4gs76fl2nxf7yr8hnalc15-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/secpick: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/nbaqxqngzm4gs76fl2nxf7yr8hnalc15-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/parallel-rsync-repos: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/rails: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/nbaqxqngzm4gs76fl2nxf7yr8hnalc15-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/background_jobs: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/web: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/storage_check: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/nbaqxqngzm4gs76fl2nxf7yr8hnalc15-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4/share/gitlab/bin/changelog: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/nbaqxqngzm4gs76fl2nxf7yr8hnalc15-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
checking for references to /build in /nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4...
/nix/store/376jga8aihx2p3cv9q3fn5wdvz9zisqf-gitlab-11.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gitlab

Partial log (click to expand)

gitlab: exit status 1
syncing
gitlab: running command: sync
gitlab: exit status 0
test script finished in 1548.63s
cleaning up
killing gitlab (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/kk501hkmqa9zp9xa0h67gjvkiv6rdwqz-vm-test-run-gitlab

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.gitlab

Partial log (click to expand)

gitlab: exit status 1
syncing
gitlab: running command: sync
gitlab: exit status 0
test script finished in 2470.25s
cleaning up
killing gitlab (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/1c50qr93dg7s2816xpykslcy6hijcf99-vm-test-run-gitlab

@flokli flokli merged commit a36f49b into NixOS:master Nov 3, 2018
@flokli flokli deleted the gitlab-11.4.4 branch November 3, 2018 11:24
@flokli flokli mentioned this pull request Nov 3, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @GrahamcOfBorg