Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: refactor and fix test #49658

Merged
merged 1 commit into from Nov 3, 2018
Merged

Conversation

globin
Copy link
Member

@globin globin commented Nov 2, 2018

Motivation for this change

Fix all the shit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @flokli @krav

@globin
Copy link
Member Author

globin commented Nov 2, 2018

@GrahamcOfBorg test gitlab

@GrahamcOfBorg

This comment has been minimized.

@GrahamcOfBorg

This comment has been minimized.

@globin
Copy link
Member Author

globin commented Nov 2, 2018

@GrahamcOfBorg test gitlab

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/im9902s3c71v69r0bncgdawivwqc14ga-gitlab-11.4.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gitlab

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/9d8a992dw65rx3n36z5bj0qqx8b44bd8-gitlab-11.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/im9902s3c71v69r0bncgdawivwqc14ga-gitlab-11.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gitlab

Partial log (click to expand)

gitlab: exit status 1
syncing
gitlab: running command: sync
gitlab: exit status 0
test script finished in 1631.42s
cleaning up
killing gitlab (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5rvk09jqv52305n66vzmw779cvk41fc7-vm-test-run-gitlab

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.gitlab

Partial log (click to expand)

gitlab: exit status 1
syncing
gitlab: running command: sync
gitlab: exit status 0
test script finished in 2075.34s
cleaning up
killing gitlab (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/iv64a7zzipvb2wpkwjynnv9i9j3p9jv0-vm-test-run-gitlab

@flokli
Copy link
Contributor

flokli commented Nov 3, 2018

Thanks a lot for taking care of this! 🎉

Test looks good. I also instantiated manually, and tinkered around in the web interface a bit.

Did not yet test cloning via ssh/https (which we could probably do in the test as well, depending on how complex it is to add a test project), but the tests now do something, and don't fail anymore.

GitLab complained I should update from 11.4.3 to 11.4.4: https://about.gitlab.com/2018/11/01/critical-security-release-gitlab-11-dot-4-dot-4-released/ - will do that in a followup PR.

@flokli flokli merged commit 93f8ff6 into NixOS:master Nov 3, 2018
@globin
Copy link
Member Author

globin commented Nov 3, 2018

I actually had a look at that, but would require adding a personal access token, which can only be done via the web interface. I might try and add a rake task to do that, simply inserting into the DB is not an option either..

@globin globin deleted the gitlab-refactor branch November 3, 2018 02:23
@flokli flokli mentioned this pull request Nov 3, 2018
9 tasks
@flokli
Copy link
Contributor

flokli commented Nov 3, 2018

@globin Is that necessary to be able to authenticate with the api, to create a dummy project?

I didn't check if and how gitlab itself does this in their integration tests, but I guess that might be useful upstream, too.

@globin
Copy link
Member Author

globin commented Nov 3, 2018

Well to create a project, we'll need to authenticate with the API, I can't see how to create a project otherwise.

@flokli
Copy link
Contributor

flokli commented Nov 3, 2018

yes, and the API only seems to support authentication via oauth tokens and personal access tokens, so having a rake task to create these seems to be a sensible thing to do…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants