New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab: refactor and fix test #49658
Conversation
@GrahamcOfBorg test gitlab |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6f817fc
to
ec7cb84
Compare
@GrahamcOfBorg test gitlab |
Success on x86_64-linux (full log) Attempted: gitlab Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: gitlab Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gitlab Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gitlab Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
Thanks a lot for taking care of this! 🎉 Test looks good. I also instantiated manually, and tinkered around in the web interface a bit. Did not yet test cloning via ssh/https (which we could probably do in the test as well, depending on how complex it is to add a test project), but the tests now do something, and don't fail anymore. GitLab complained I should update from 11.4.3 to 11.4.4: https://about.gitlab.com/2018/11/01/critical-security-release-gitlab-11-dot-4-dot-4-released/ - will do that in a followup PR. |
I actually had a look at that, but would require adding a personal access token, which can only be done via the web interface. I might try and add a rake task to do that, simply inserting into the DB is not an option either.. |
@globin Is that necessary to be able to authenticate with the api, to create a dummy project? I didn't check if and how gitlab itself does this in their integration tests, but I guess that might be useful upstream, too. |
Well to create a project, we'll need to authenticate with the API, I can't see how to create a project otherwise. |
yes, and the API only seems to support authentication via oauth tokens and personal access tokens, so having a rake task to create these seems to be a sensible thing to do… |
Motivation for this change
Fix all the shit.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @flokli @krav