Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minishift: init at 1.25.0 #48736

Merged
merged 1 commit into from Oct 20, 2018
Merged

minishift: init at 1.25.0 #48736

merged 1 commit into from Oct 20, 2018

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Oct 20, 2018

Motivation for this change

New package to set up a local developer instance of OpenShift.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: minishift

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: minishift

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fllxcsakyx9fqfya3bylab5b4l23v3as-minishift-1.25.0-bin
shrinking /nix/store/fllxcsakyx9fqfya3bylab5b4l23v3as-minishift-1.25.0-bin/bin/.minishift-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fllxcsakyx9fqfya3bylab5b4l23v3as-minishift-1.25.0-bin/bin
patching script interpreter paths in /nix/store/fllxcsakyx9fqfya3bylab5b4l23v3as-minishift-1.25.0-bin
checking for references to /build in /nix/store/fllxcsakyx9fqfya3bylab5b4l23v3as-minishift-1.25.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: minishift

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6kjkmp91a3zcs1firhv2817glbrn5rnn-minishift-1.25.0-bin
shrinking /nix/store/6kjkmp91a3zcs1firhv2817glbrn5rnn-minishift-1.25.0-bin/bin/.minishift-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6kjkmp91a3zcs1firhv2817glbrn5rnn-minishift-1.25.0-bin/bin
patching script interpreter paths in /nix/store/6kjkmp91a3zcs1firhv2817glbrn5rnn-minishift-1.25.0-bin
checking for references to /build in /nix/store/6kjkmp91a3zcs1firhv2817glbrn5rnn-minishift-1.25.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip

offlinehacker
offlinehacker reviewed Oct 20, 2018
View reviewed changes
pkgs/applications/networking/cluster/minishift/default.nix

postPatch = ''
substituteInPlace vendor/github.com/containers/image/storage/storage_image.go \
--replace 'nil, diff' 'diff'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this upstram bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this seems to be fixed on master.

@offlinehacker offlinehacker merged commit 8ff3df3 into NixOS:master Oct 20, 2018
@fpletz fpletz deleted the pkg/minishift branch October 20, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpletz @GrahamcOfBorg @offlinehacker