Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.isStorePath: fix false result when given a path object #48744

Merged
merged 1 commit into from Oct 28, 2018
Merged

lib.isStorePath: fix false result when given a path object #48744

merged 1 commit into from Oct 28, 2018

Conversation

timbertson
Copy link
Contributor

@timbertson timbertson commented Oct 20, 2018 •
edited

Motivation for this change

Fixes #48743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timbertson
lib.isStorePath: fix false result when passed a path object
d984c55 
Since `isStorePath` relies on comparing against builtins.storeDir
(a string), we need to convert the input into a string as well.
@timokau timokau mentioned this pull request Oct 21, 2018
Closed
@Mic92 Mic92 requested a review from Profpatsch October 21, 2018 22:03
roberth
roberth approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the duplicate test case, it seems that the intent was indeed to allow paths. Within nixpkgs, it is only used in lib.types.package.

This looks like an improvement to me.

@roberth
Copy link
Member

roberth commented Oct 28, 2018

The issue description shows that it's a regression.

@roberth roberth merged commit 6b3bff4 into NixOS:master Oct 28, 2018
@Profpatsch
Copy link
Member

Profpatsch commented Oct 29, 2018 •
edited

Am I the only one who regularly wants to add a comment to an issue, only to have it never submitted by Github’s stupid review workflow? The UI is really bad.

(I added a comment to this some days ago, but it was never submitted by GH)

@timbertson timbertson deleted the isStorePath branch August 3, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timbertson @roberth @Profpatsch @GrahamcOfBorg