Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thonny: 3.0.0b3 -> 3.0.1 #48755

Merged
merged 1 commit into from Oct 20, 2018
Merged

thonny: 3.0.0b3 -> 3.0.1 #48755

merged 1 commit into from Oct 20, 2018

Conversation

leenaars
Copy link
Contributor

Motivation for this change

Move from beta to release, with some new dependencies (mypy and pyperclip)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

timokau
timokau requested changes Oct 20, 2018
View reviewed changes
pkgs/applications/editors/thonny/default.nix Outdated
pylint
mypy
pyperclip
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation here. nipxkgs policy is indentation by two spaces. Also the jedi should be in its own line, pyserial indented like everything else and the closing bracket at the same indentation level as the line with the opening bracket. Like this:

propagatedBuildInputs = with python3.pkgs; [
  jedi
  pyserial
  tkinter
  docutils
  pylint
  mypy
  pyperclip
];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timokau : Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@timokau timokau merged commit d75c558 into NixOS:master Oct 20, 2018
@leenaars leenaars deleted the thonny branch October 21, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @timokau @GrahamcOfBorg