Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.clang_complete: fix path to libclang.so #48750

Merged
merged 1 commit into from Oct 20, 2018
Merged

vimPlugins.clang_complete: fix path to libclang.so #48750

merged 1 commit into from Oct 20, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 20, 2018 •
edited

Motivation for this change

With the current plugin configuration I get the following error when
opening a C/C++ file in ViM:

"main.cpp" 246L, 7522C
Loading libclang failed, completion won't be available. Are you sure '/nix/store/jdz3pbl853dw6k0qg54ifd5fplkq7xl8-cla
ng-3.9.1/lib/libclang.so' contains libclang?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
vimPlugins.clang_complete: fix path to libclang.so
d301d5c 
With the current plugin configuration I get the following error when
opening a C/C++ file in ViM:

```
"main.cpp" 246L, 7522C
Loading libclang failed, completion won't be available. Are you sure '/nix/store/jdz3pbl853dw6k0qg54ifd5fplkq7xl8-cla
ng-3.9.1/lib/libclang.so' contains libclang?
```
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vimPlugins.clang_complete

Partial log (click to expand)

patching sources
configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yazf4w9k2jfh03qq5pi74g99q66i19xd-vimplugin-clang_complete-2018-09-19
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/yazf4w9k2jfh03qq5pi74g99q66i19xd-vimplugin-clang_complete-2018-09-19
checking for references to /build in /nix/store/yazf4w9k2jfh03qq5pi74g99q66i19xd-vimplugin-clang_complete-2018-09-19...
/nix/store/yazf4w9k2jfh03qq5pi74g99q66i19xd-vimplugin-clang_complete-2018-09-19

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vimPlugins.clang_complete

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kn3aa32adr53q8dq3yvm1zm59j33s2v1-vimplugin-clang_complete-2018-09-19
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/kn3aa32adr53q8dq3yvm1zm59j33s2v1-vimplugin-clang_complete-2018-09-19
checking for references to /build in /nix/store/kn3aa32adr53q8dq3yvm1zm59j33s2v1-vimplugin-clang_complete-2018-09-19...
/nix/store/kn3aa32adr53q8dq3yvm1zm59j33s2v1-vimplugin-clang_complete-2018-09-19

@Mic92
Copy link
Member

Mic92 commented Oct 20, 2018

This probably also affect 18.09.

@Ma27
Copy link
Member Author

Ma27 commented Oct 20, 2018

ack 👍
The thing is, in 18.09 the additional-nix-code stuff is still used to generate the vim plugins expression, so a simple backport won't be possible, I'll file a second patch for this tonight (or tomorrow,let's see)

@Mic92 Mic92 merged commit 9b1c2c4 into NixOS:master Oct 20, 2018
@Ma27 Ma27 deleted the fix-vim-clang-completion branch October 20, 2018 23:45
@Ma27
Copy link
Member Author

Ma27 commented Oct 20, 2018

will backport tomorrow, too tired now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @GrahamcOfBorg @Mic92 @timokau