Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable/pylint #48748

Merged
merged 2 commits into from Oct 20, 2018
Merged

Stable/pylint #48748

merged 2 commits into from Oct 20, 2018

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Oct 20, 2018 •
edited

Motivation for this change

Pylint won't work with python 2.7, so I backport two commits from master, which add
pylint (and astroid) in last versions capable to work with python2.7 (conditionaly, only for py2.7)

Before merge:

[avn@bulldozer:pts/5]~/nixos/nixpkgs% nix-build -A pkgs.python27Packages.pylint                                                                                                
error: pylint-2.1.1 not supported for interpreter python2.7

After:

[avn@bulldozer:pts/5]~/nixos/nixpkgs1% nix-build -A pkgs.python27Packages.pylint                                                                                               
these derivations will be built:
  /nix/store/nw8l1rw57b3n34w60w2rdpa8jgxp9r8v-python2.7-astroid-1.6.5.drv
  /nix/store/04nqnrv7p404mr1gcfn210i11m51cypk-python2.7-pylint-1.9.2.drv
these paths will be fetched (1.67 MiB download, 5.82 MiB unpacked):
...<some output stripped>...
/nix/store/hyl3qjrrvfamlds7hdnh9yfwbza0jsk6-python2.7-pylint-1.9.2
[avn@bulldozer:pts/5]~/nixos/nixpkgs% ./result/bin/pylint --version                                                                                                            
No config file found, using default configuration
pylint 1.9.2, 
astroid 1.6.5
Python 2.7.15 (default, Apr 29 2018, 23:18:59) 
[GCC 7.3.0]

Python 2.6 still have latest pylint (building output skipped)

[avn@bulldozer:pts/5]~/nixos/nixpkgs%  nix-build -A pkgs.python36Packages.pylint
/nix/store/sq97g8z3g5q2v51nsmp4d5acbkm2yq6g-python3.6-pylint-2.1.1
[avn@bulldozer:pts/5]~/nixos/nixpkgs32% ./result/bin/pylint --version                                                                                                          
pylint 2.1.1
astroid 2.0.4
Python 3.6.6 (default, Jun 27 2018, 05:47:41) 
[GCC 7.3.0]
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

/cc @samueldr

@lopsided98 @avnik
python2Packages.astroid: init at 1.6.5
e205b04 
Older version backported from master, as requirement for pylint 1.9.2

(cherry picked from commit 4f09e05)
@lopsided98 @avnik
python2Packages.pylint: init at 1.9.2
4bbcb54 
Backport of pylint 1.9.2, required for older python2.7
(2.x versions of pylint work only with python 3.4+)

(cherry picked from commit 67ea567)
@avnik avnik requested a review from FRidh as a code owner October 20, 2018 14:33
@FRidh FRidh merged commit 0da77aa into NixOS:release-18.09 Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avnik @FRidh @GrahamcOfBorg @lopsided98