Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epson-workforce-635-nx625-series: init at 1.0.1 #48752

Merged
merged 4 commits into from Jan 14, 2019
Merged

epson-workforce-635-nx625-series: init at 1.0.1 #48752

merged 4 commits into from Jan 14, 2019

Conversation

jorsn
Copy link
Member

@jorsn jorsn commented Oct 20, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    nix path-info -S nixpkgs.epson-workforce-635-nx625-series or what? Before and after what?
  • Fits CONTRIBUTING.md.
More

Tested with my Epson Stylus Office BX525WD wireless inkjet printer with success.

@jorsn
epson-workforce-635-nx625-series: fixed build errors
238e953 
variables `maintainers` and `licenses` were invisible, leading to build
errors; fixed this.
@jorsn
Copy link
Member Author

jorsn commented Oct 20, 2018

From GrahamcOfBorg-eval log:

access to URI 'https://download.ebz.epson.net/dsc/op/stable/SRPMS/epson-inkjet-printer-workforce-635-nx625-series-1.0.1-1lsb3.2.src.rpm' is forbidden in restricted mode

I have no idea what to do about this.

Mic92
Mic92 reviewed Oct 21, 2018
View reviewed changes
pkgs/misc/drivers/epson-workforce-635-nx625-series/default.nix Outdated
name = "epson-inkjet-printer-workforce-635-nx625-series";
version = "1.0.1";

src = builtins.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use fetchurl instead of builtins.fetchurl to avoid the evaluation warning.

@jorsn
epson-workforce-635-nx625-series: use lib.fetchurl
e0809da 
builtins.fetchurl (was used) cannot access uris not in `allowed-uris`
when built in restricted mode (like ofborg does)
@Mic92
Copy link
Member

Mic92 commented Oct 21, 2018

@GrahamcOfBorg build epson-workforce-635-nx625-series

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: epson-workforce-635-nx625-series

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: epson-workforce-635-nx625-series

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: epson-workforce-635-nx625-series

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Mic92
Mic92 reviewed Oct 22, 2018
View reviewed changes
pkgs/misc/drivers/epson-workforce-635-nx625-series/default.nix
};
'';
downloadPage = https://download.ebz.epson.net/dsc/du/02/DriverDownloadInfo.do?LG2=EN&CN2=&DSCMI=16857&DSCCHK=4334d3487503d7f916ccf5d58071b05b7687294f;
license = with lib.licenses; [ lgpl21 epson ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the whole source code is dual-licensed, dropping epson is better because it can be built on hydra then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package includes lgpl source code and proprietary object files which are (dynamically) linked against. Since the proprietary and lgpl parts are distributed in one rpm I don't think one may leave out the epson license even if splitting the package into two subpackages in nixpkgs.

@jorsn
Copy link
Member Author

jorsn commented Dec 16, 2018 •
edited

@Mic92 Is there any problem why this doesn't get merged? After all, this is without any comments or failed tests since Oct 22.

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2019

@jorsn Thanks for the update. This pull request simply went under.

@Mic92 Mic92 merged commit ff0dc34 into NixOS:master Jan 14, 2019
@jorsn jorsn deleted the new.epson-workforce-635-nx625-series branch March 1, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jorsn @Mic92 @GrahamcOfBorg @samueldr @Janik-Haag