Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/eternal-terminal: init new module. #48728

Merged
merged 3 commits into from Oct 25, 2018
Merged

nixos/eternal-terminal: init new module. #48728

merged 3 commits into from Oct 25, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Oct 20, 2018

Motivation for this change

eternal-terminal is like ssh; it requires a daemon to be running if you want to allow remote machines to connect to you. This module provides this.

I have based the generated systemd unit and config file on the files provided in the et repo (systemd unit and cfg file). However, if anyone has experience or expertise with better ways to configure it, I am all ears. In particular, I have made verbose, silent and logsize as module parameters, but these aren't really described on the ET website and I'm not sure exactly how to control them.

In addition, I think that when the remote et connects to the server, it logs in and then runs etterminal. Because of this, the etterminal binary needs to be available to it at that time. To solve this, I added the eternal-terminal package to environment.systemPackages, but this doesn't seem that elegant. If there is a better way, we can change to that.

This is the first unit I have made. So all feedback is very welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Ma27
Ma27 requested changes Oct 20, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first of all, thanks a lot for contributing a module for eternal terminal! The idea behind this tool seems quite interesting, I'm currently wondering if I could benefit from this as well :)

However I added some comments about the option's design in the module I'd like to see fixed before merging this.

nixos/modules/services/networking/eternal-terminal.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/eternal-terminal.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/eternal-terminal.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/eternal-terminal.nix Outdated Show resolved Hide resolved
@qolii
Copy link
Contributor Author

qolii commented Oct 20, 2018

@Ma27, thanks for your feedback! My system is suffering through a big rebuild, so I'll need to make these changes in a little bit. Back soon!

@qolii
Copy link
Contributor Author

qolii commented Oct 20, 2018

@Ma27, I think I addressed all your comments so far. Let me know if there is anything else.

@Ma27
Copy link
Member

Ma27 commented Oct 21, 2018

the change seems fine so far. Please give me some time to test this on one of my servers to confirm its functionality (and I like the idea of this,so I'd like to try it out first:) ).

@Ma27
Copy link
Member

Ma27 commented Oct 21, 2018

checked it on one of my servers with a recent 18.09 and the eternal-terminal changes (bump and module) cherry-picked. Except the issue above the module seems fine :)

@qolii
Copy link
Contributor Author

qolii commented Oct 25, 2018

@Ma27, thanks for your careful review! Do you think we are good to go? This is working well for me.

Ma27
Ma27 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned earlier I've checked this on oneof my servers and it worked fine, code looks good as well, so this should be safe to merge 👍

@Ma27 Ma27 merged commit 5dc1748 into NixOS:master Oct 25, 2018
@Ma27
Copy link
Member

Ma27 commented Oct 25, 2018

and btw, thanks a lot for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qolii @Ma27 @GrahamcOfBorg