Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn - not all switches work #1684

Closed
kaleara opened this issue Oct 13, 2018 · 4 comments
Closed

Spawn - not all switches work #1684

kaleara opened this issue Oct 13, 2018 · 4 comments
Labels
bug An actual error or unwanted behavior. good first issue Low hanging fruit for those wanting to help out. Hacktoberfest Help out in October and win prizes! https://hacktoberfest.digitalocean.com/

Comments

@kaleara
Copy link

kaleara commented Oct 13, 2018 •
edited by Griatch

Brief summary of issue / Description of requested feature:

Edit and examine are listed as switches of spawn in the command's help but don't function.

Steps to reproduce the issue / Reasons for adding feature:

  1. help spawn (examine and edit) are listed as switches
  2. spawn/edit returns "spawn: Extra switch "/edit" ignored" and gives usage message
  3. same for spawn/examine
@Griatch Griatch added bug An actual error or unwanted behavior. Hacktoberfest Help out in October and win prizes! https://hacktoberfest.digitalocean.com/ good first issue Low hanging fruit for those wanting to help out. master-branch labels Oct 14, 2018
@Henddher
Copy link
Contributor

Can I tackle this one too?

🎣 Hacktoberfest

@Henddher
Copy link
Contributor

Henddher commented Oct 19, 2018 •
edited

Hi @Griatch,

I've just pushed PR #1699 tagged as [UNCLEAR_REQS].

Basically, I am adding few test-cases to baseline the existing behavior - disregarding the desired behavior.

In some cases, behavior matches @kaleara description. And by going by the help of the command, it seems like the actual behavior is correct in some cases but wrong in others?

Hence, clarifications of expected behavior is needed

Can you shed some light?

I'll move the discussion to the PR.

@Henddher Henddher mentioned this issue Oct 19, 2018
Merged
@Henddher
Copy link
Contributor

@Griatch, after merging #1699. This can be closed right?

@Griatch
Copy link
Member

Griatch commented Oct 26, 2018

@Henddher Correct, thanks for reminding me.

@Griatch Griatch closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An actual error or unwanted behavior. good first issue Low hanging fruit for those wanting to help out. Hacktoberfest Help out in October and win prizes! https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Griatch @Henddher @kaleara