Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos pykms: run via DynamicUser #48101

Merged
merged 1 commit into from Jan 18, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We don't need to allocate a fixed user for this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

wantedBy = [ "multi-user.target" ];
script = with pkgs; ''
# python programs with DynamicUser = true require HOME to be set
export HOME=${home}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to set this in the script rather than with systemd.services.pykms.environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but just not a very a good one... ;-)

@peterhoeg peterhoeg changed the title nixos pykms: run via DynamicUser nixos pykms: run via DynamicUser [WIP] Oct 15, 2018
@peterhoeg
Copy link
Member Author

This isn't tested yet (missing a lib. I see)

@peterhoeg peterhoeg force-pushed the f/pykms_master branch 2 times, most recently from 1b2adb0 to 85e2d2b Compare October 15, 2018 14:23
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd say merge if you've tested it :)

@peterhoeg peterhoeg changed the title nixos pykms: run via DynamicUser [WIP] nixos pykms: run via DynamicUser Jan 18, 2019
@peterhoeg peterhoeg merged commit 9f5b5fe into NixOS:master Jan 18, 2019
@peterhoeg peterhoeg deleted the f/pykms_master branch January 18, 2019 07:52
@peterhoeg peterhoeg restored the f/pykms_master branch January 18, 2019 09:14
@peterhoeg peterhoeg deleted the f/pykms_master branch September 24, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants