Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pidgin-opensteamworks: 1.6.1 -> git-2018-08-02 #48102

Merged
merged 1 commit into from Oct 21, 2018
Merged

pidgin-opensteamworks: 1.6.1 -> git-2018-08-02 #48102

merged 1 commit into from Oct 21, 2018

Conversation

Shados
Copy link
Member

@Shados Shados commented Oct 9, 2018

Motivation for this change

I've been somewhat hesitant to update this because there haven't been any actual releases after 1.6.1, but there have been a few relevant fixes and additions in the three years since then, so to git versions we go...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes Oct 9, 2018
View reviewed changes
.../applications/networking/instant-messengers/pidgin-plugins/pidgin-opensteamworks/default.nix Outdated
@@ -2,22 +2,21 @@

stdenv.mkDerivation rec {
name = "pidgin-opensteamworks-${version}";
version = "1.6.1";
version = "git-2018-08-02";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On package naming the manual rather suggest unstable-2018-08-02

Otherwise you get half the repository when looking for "git" https://nixos.org/nixpkgs/manual/#sec-package-naming :)

@Shados Shados force-pushed the update/pidgin-opensteamworks/git-2018-08-02 branch from f8e4b5c to 8dd8360 Compare October 10, 2018 11:09
@Shados
Copy link
Member Author

Shados commented Oct 10, 2018

@c0bw3b Sure, I've gone and fixed that. Although I suspect the intention is more about version names being independent from the chosen SVC; grep -RP 'git-(?:\d|\$)' ~/nixpkgs/ isn't a very complicated pattern, and gives only a handful of false positives. On that note: it looks like there's 100-ish packages using git-${somedate}, might be a good idea for someone to do a cleanup PR to change those over.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 10, 2018

Yes I also noticed the git-date naming scheme had been used quite a lot already.. :/

@c0bw3b c0bw3b merged commit dc6e4f9 into NixOS:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shados @c0bw3b @GrahamcOfBorg