Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfssl: allow building on all platforms #48093

Merged
merged 2 commits into from Oct 12, 2018
Merged

cfssl: allow building on all platforms #48093

merged 2 commits into from Oct 12, 2018

Conversation

edude03
Copy link
Contributor

@edude03 edude03 commented Oct 9, 2018

Motivation for this change

CFSSL is a go package, and thus can be built on all platforms go supports, not just linux. I use this patch locally to use cfssl on OSX.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build cfssl

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cfssl

Partial log (click to expand)

these paths will be fetched (11.55 MiB download, 75.72 MiB unpacked):
  /nix/store/nwqcqzwhxsdwg7d57is85bbshdg363z0-cfssl-1.3.2-bin
copying path '/nix/store/nwqcqzwhxsdwg7d57is85bbshdg363z0-cfssl-1.3.2-bin' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/nwqcqzwhxsdwg7d57is85bbshdg363z0-cfssl-1.3.2-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cfssl

Partial log (click to expand)

these paths will be fetched (9.83 MiB download, 70.03 MiB unpacked):
  /nix/store/jxc25z0k9dqbikjw9np1mhsmnab7h0n4-cfssl-1.3.2-bin
copying path '/nix/store/jxc25z0k9dqbikjw9np1mhsmnab7h0n4-cfssl-1.3.2-bin' from 'https://cache.nixos.org'...
/nix/store/jxc25z0k9dqbikjw9np1mhsmnab7h0n4-cfssl-1.3.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cfssl

Partial log (click to expand)

find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
find: '/nix/store/v5h7bn7hvqvaqcwsshy1hn99gz8agbgi-cfssl-1.3.2': No such file or directory
/nix/store/ckydx6zqpgmv9x3wxrk1mp357lgvizbs-cfssl-1.3.2-bin

@fpletz fpletz merged commit 6ab21f4 into NixOS:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edude03 @infinisil @GrahamcOfBorg @fpletz