Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] apvlv: add .desktop file #48095

Merged
merged 1 commit into from Oct 15, 2018
Merged

[RDY] apvlv: add .desktop file #48095

merged 1 commit into from Oct 15, 2018

Conversation

teto
Copy link
Member

@teto teto commented Oct 9, 2018 •
edited

Motivation for this change

While waiting for zathura synctex fixes to be in nixos-unstable, I switched to apvlv but as there is no .desktop, I had no default pdf applications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apvlv

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5/bin/apvlv
shrinking RPATHs of ELF executables and libraries in /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5
shrinking /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5/bin/.apvlv-wrapped
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5/bin
patching script interpreter paths in /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5
checking for references to /build in /nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5...
/nix/store/lli6ywj1cnfnwgfngnwhfz3c6zmn7kcj-apvlv-0.1.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apvlv

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5/bin/apvlv
shrinking RPATHs of ELF executables and libraries in /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5
shrinking /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5/bin/.apvlv-wrapped
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5/bin
patching script interpreter paths in /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5
checking for references to /build in /nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5...
/nix/store/dnc1fd3xy18xqdww8bbsyiaxzf6lnbk2-apvlv-0.1.5

@teto teto changed the title apvlv: add .desktop file [RDY] apvlv: add .desktop file Oct 15, 2018
@lheckemann
Copy link
Member

What's [RDY]?

lheckemann
lheckemann reviewed Oct 15, 2018
View reviewed changes
pkgs/applications/misc/apvlv/default.nix Outdated
@@ -52,6 +52,11 @@ stdenv.mkDerivation rec {
mkdir -p $out/share/doc/apvlv/
cp ../Startup.pdf $out/share/doc/apvlv/Startup.pdf
cp ../main_menubar.glade $out/share/doc/apvlv/main_menubar.glade
''
+ stdenv.lib.optionalString (!stdenv.isDarwin) ''
# copy and patch the original apvlv.desktop file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention patching, but I don't see any (explicit) patching here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed an update with a more elegant "install -D"

@teto
Copy link
Member Author

teto commented Oct 15, 2018

What's [RDY]?

It's a convention used by some projects, for instance neovim has a bot that classifes PRs based on this targ https://github.com/neovim/neovim/pulls . RDY => ready, RFC> request for comment, WIP=work in progress.
I believe nixpkgs could use this convention to help with PR triage.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apvlv

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5/bin/apvlv
shrinking RPATHs of ELF executables and libraries in /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5
shrinking /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5/bin/.apvlv-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5/bin
patching script interpreter paths in /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5
checking for references to /build in /nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5...
/nix/store/cx1rfc4iw34slghdlx4vz9sgzbday2ks-apvlv-0.1.5

@lheckemann lheckemann merged commit ad85b9a into NixOS:master Oct 15, 2018
@teto teto deleted the apvlv branch October 15, 2018 09:48
@teto
Copy link
Member Author

teto commented Oct 15, 2018

ty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apvlv

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5/bin/apvlv
shrinking RPATHs of ELF executables and libraries in /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5
shrinking /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5/bin/.apvlv-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5/bin
patching script interpreter paths in /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5
checking for references to /build in /nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5...
/nix/store/2hdn06zmijllmhnr1br13slb1kczl2yp-apvlv-0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @GrahamcOfBorg @lheckemann