Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud : added options to customize the listening address/port #47868

Closed
wants to merge 1 commit into from
Closed

nixos/nextcloud : added options to customize the listening address/port #47868

wants to merge 1 commit into from

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Oct 4, 2018

Motivation for this change

I added options to customize the listening address and port

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Oct 4, 2018
View reviewed changes
nixos/modules/services/web-apps/nextcloud.nix
nginx.enable = mkEnableOption "nginx vhost management";
nginx = {
enable = mkEnableOption "nginx vhost management";
addr = mkOption {
Copy link
Member

@Mic92 Mic92 Oct 4, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really duplicate this or rather add documentation how to access/extend the vhost documentation of nginx?

nginx.enable = mkOption {
  type = types.bool;
  default = false;
  description = ''
    Enable nginx vhost management.
    Further nginx configuration can be done by adapting <literal>nginx.virtualHosts.&lt;hostName&gt;</literal>.
    See <insert-link-to-virtualHosts-doc> for further information.
  '';
}:

Otherwise we also end up duplicating options like letsencrypt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for documenting on how to extend this from the nginx module, instead of duplicating options.

@Mic92 Mic92 mentioned this pull request Oct 5, 2018
Closed
@Vskilet Vskilet mentioned this pull request Oct 8, 2018
Merged
9 tasks
@Vskilet
Copy link
Contributor Author

Vskilet commented Oct 8, 2018

New Pull request #48041

@Vskilet Vskilet closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vskilet @Mic92 @flokli @GrahamcOfBorg