Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages_latest.ocaml: 4.07.0 -> 4.07.1 #47875

Merged
merged 1 commit into from Oct 30, 2018
Merged

ocamlPackages_latest.ocaml: 4.07.0 -> 4.07.1 #47875

merged 1 commit into from Oct 30, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 4, 2018

Motivation for this change

Bugfix release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 4, 2018

@GrahamcOfBorg build ocamlPackages_latest.merlin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages_latest.merlin

Partial log (click to expand)

File "src/ocaml/typer/typing/typecore.ml", line 3308, characters 10-22:
Error: The constructor Ignored_bool expects 1 argument(s),
       but is applied here to 0 argument(s)
make[2]: *** [OCamlMakefile:1079: src/ocaml/typer/typing/typecore.cmx] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-merlin-3.1.0.drv-0/source'
make[1]: *** [OCamlMakefile:780: native-code] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-merlin-3.1.0.drv-0/source'
make: *** [Makefile:59: ocamlmerlin-server] Error 2
builder for '/nix/store/kw7pp449666hrr40bzj4hkwpbkzsg85d-merlin-3.1.0.drv' failed with exit code 2
error: build of '/nix/store/kw7pp449666hrr40bzj4hkwpbkzsg85d-merlin-3.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages_latest.merlin

Partial log (click to expand)

File "src/ocaml/typer/typing/typecore.ml", line 3308, characters 10-22:
Error: The constructor Ignored_bool expects 1 argument(s),
       but is applied here to 0 argument(s)
make[2]: *** [OCamlMakefile:1079: src/ocaml/typer/typing/typecore.cmx] Error 2
make[2]: Leaving directory '/build/source'
make[1]: *** [OCamlMakefile:780: native-code] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:59: ocamlmerlin-server] Error 2
builder for '/nix/store/llnx9mfna04z6i4s1mx7yh5p8snlqk1r-merlin-3.1.0.drv' failed with exit code 2
error: build of '/nix/store/llnx9mfna04z6i4s1mx7yh5p8snlqk1r-merlin-3.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: ocamlPackages_latest.merlin

Partial log (click to expand)

File "src/ocaml/typer/typing/typecore.ml", line 3308, characters 10-22:
Error: The constructor Ignored_bool expects 1 argument(s),
       but is applied here to 0 argument(s)
make[2]: *** [OCamlMakefile:1079: src/ocaml/typer/typing/typecore.cmx] Error 2
make[2]: Leaving directory '/build/source'
make[1]: *** [OCamlMakefile:780: native-code] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:59: ocamlmerlin-server] Error 2
builder for '/nix/store/60x759lbw61j5yqxnab38vbf5xyh9ldg-merlin-3.1.0.drv' failed with exit code 2
error: build of '/nix/store/60x759lbw61j5yqxnab38vbf5xyh9ldg-merlin-3.1.0.drv' failed

@vbgl vbgl mentioned this pull request Oct 8, 2018
Merged
9 tasks
@kamilchm
Copy link
Member

@vbgl rebuild?

@vbgl
Copy link
Contributor Author

vbgl commented Oct 23, 2018

What do you mean?

@kamilchm
Copy link
Member

I thought this couldn't be merged because of failed build before merlin update.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 24, 2018

That’s right. There are a few other things that break (e.g. camlp5) but it’s probably not blocking (and tricky to fix).

@vbgl vbgl merged commit 0a24919 into NixOS:master Oct 30, 2018
@vbgl vbgl deleted the ocaml-4.07.1 branch October 30, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @kamilchm