Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.webtorrent-cli: add node-gyp dependency, fixes build #47869

Merged
merged 1 commit into from Oct 4, 2018
Merged

nodePackages.webtorrent-cli: add node-gyp dependency, fixes build #47869

merged 1 commit into from Oct 4, 2018

Conversation

schneefux
Copy link
Contributor

Motivation for this change

Fixes webtorrent-cli build, see #47525

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

@GrahamcOfBorg build nodePackages.webtorrent-cli

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.webtorrent-cli

Partial log (click to expand)

wrong ELF type
shrinking /nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/bufferutil/prebuilds/linux-x64/node-napi.node
patching script interpreter paths in /nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3
/nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/json2proto: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2r6vcc5n711k1nx912hsxnkn24nydxjb-nodejs-8.11.4/bin/node"
/nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/proto2js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2r6vcc5n711k1nx912hsxnkn24nydxjb-nodejs-8.11.4/bin/node"
/nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/ecstatic/lib/ecstatic.js: interpreter directive changed from " /usr/bin/env node" to "/nix/store/2r6vcc5n711k1nx912hsxnkn24nydxjb-nodejs-8.11.4/bin/node"
checking for references to /build in /nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3...
wrong ELF type
wrong ELF type
/nix/store/fa06ygsabyb0fhfxdp9ls6fcsxx8lm79-node-webtorrent-cli-1.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages.webtorrent-cli

Partial log (click to expand)

bufferutil@4.0.0 /nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/bufferutil
node-gyp-build@3.4.0 /nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/node-gyp-build
utf-8-validate@5.0.1 /nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/utf-8-validate
up to date in 0.797s
post-installation fixup
patching script interpreter paths in /nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3
/nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/ecstatic/lib/ecstatic.js: interpreter directive changed from " /usr/bin/env node" to "/nix/store/ghfhw6xza78bl7d340kipj06cazlircz-nodejs-8.11.4/bin/node"
/nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/json2proto: interpreter directive changed from "/usr/bin/env node" to "/nix/store/ghfhw6xza78bl7d340kipj06cazlircz-nodejs-8.11.4/bin/node"
/nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/proto2js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/ghfhw6xza78bl7d340kipj06cazlircz-nodejs-8.11.4/bin/node"
/nix/store/1cnvfg72yh404n055s36x0p264ri6ays-node-webtorrent-cli-1.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.webtorrent-cli

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3
shrinking /nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/utf-8-validate/prebuilds/linux-x64/node-napi.node
shrinking /nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/bufferutil/prebuilds/linux-x64/node-napi.node
patching script interpreter paths in /nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3
/nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/proto2js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/hshlb7ysskab4pa0vqabz50kv9mc1cjd-nodejs-8.11.4/bin/node"
/nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/protobufjs/bin/json2proto: interpreter directive changed from "/usr/bin/env node" to "/nix/store/hshlb7ysskab4pa0vqabz50kv9mc1cjd-nodejs-8.11.4/bin/node"
/nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3/lib/node_modules/webtorrent-cli/node_modules/ecstatic/lib/ecstatic.js: interpreter directive changed from " /usr/bin/env node" to "/nix/store/hshlb7ysskab4pa0vqabz50kv9mc1cjd-nodejs-8.11.4/bin/node"
checking for references to /build in /nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3...
/nix/store/p7z6hjsbjm8m7kb8s3vjn3xbcn7vx1nl-node-webtorrent-cli-1.12.3

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

Is this also needed on 18.03 or 18.09?

@Mic92 Mic92 merged commit 8c2c14a into NixOS:master Oct 4, 2018
@schneefux
Copy link
Contributor Author

@Mic92 18.03 doesn't have the package, but 18.09 and it doesn't build there so yes.

@Mic92
Copy link
Member

Mic92 commented Oct 6, 2018

299814b

@matthewbauer matthewbauer mentioned this pull request Oct 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schneefux @Mic92 @GrahamcOfBorg