Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elvish: provide the compiled version #47867

Merged
merged 1 commit into from Oct 4, 2018
Merged

elvish: provide the compiled version #47867

merged 1 commit into from Oct 4, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 4, 2018

Motivation for this change

Without this fix, elvish -version displays "unknown"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
elvish: provide the compiled version
9d49cf1 
Without this fix, `elvish -version` displays "unknown"
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: elvish

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin
shrinking /nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin/bin/elvish
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin/bin
patching script interpreter paths in /nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin
checking for references to /build in /nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
/nix/store/rkn5zbzh8xlragxg36w6gqy1xgs5wsh0-elvish-0.12-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: elvish

Partial log (click to expand)

find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
find: '/nix/store/ckqgqkwvgrismwmapxc0ssi0hs8kwbl7-elvish-0.12': No such file or directory
/nix/store/2pjvl2jx4ivk8k5fm87qq7wjfmac7hci-elvish-0.12-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elvish

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin
shrinking /nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin/bin/elvish
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin/bin
patching script interpreter paths in /nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin
checking for references to /build in /nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/hr6grg701h3gwbnq2knrn05m6zgprfq4-elvish-0.12-bin

@Mic92 Mic92 merged commit c67c243 into NixOS:master Oct 4, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

backport: 5399898

@zimbatm zimbatm deleted the elvish-version branch October 4, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @GrahamcOfBorg @Mic92