Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor security backports for 18.03 #47873

Merged
merged 3 commits into from Oct 4, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

(cherry picked from commit 265c5fc)
Reason: Security update: "Solves a vulnerability in the File view and
All Pages view that would allow XSS."
(cherry picked from commit 18b468e)
Reason: Security update: "Depend on new version of gollum-lib that
relies on a patched version of sanitize, which solves a vulnerability
(CVE-2018-3740). See gollum/gollum-lib#296."
Reason: Security update: "fix include bypass of EntryFilter#filter
symlink check".
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

1 gem installed
checking for references to /build in /nix/store/948cbzxnps28qxanfw40m7g5v1fmaay7-ruby2.4.4-jekyll-sitemap-1.2.0...
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ls2x5nn1lq55l1y4fbm1nsf3nrcah1r4-ruby2.4.4-jemoji-0.10.1
patching script interpreter paths in /nix/store/ls2x5nn1lq55l1y4fbm1nsf3nrcah1r4-ruby2.4.4-jemoji-0.10.1
checking for references to /build in /nix/store/ls2x5nn1lq55l1y4fbm1nsf3nrcah1r4-ruby2.4.4-jemoji-0.10.1...
building '/nix/store/i0568mjyir4x8nqkd6j1f9r2xi89yjnp-jekyll-3.7.4.drv'...
created 134 symlinks in user environment
/nix/store/qb5xnn3v8gal37pklb1v7bcvbszcqzg8-gollum-4.1.4
/nix/store/mrwcgw8mdk5h37pnyqbjkg5bph2qkbxk-jekyll-3.7.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

  Bin dir: /nix/store/qdvspkkwgaa0rc7cvkc7kxc6329yv1l9-ruby2.4.4-jemoji-0.10.1/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/qdvspkkwgaa0rc7cvkc7kxc6329yv1l9-ruby2.4.4-jemoji-0.10.1/lib/ruby/gems/2.4.0
Successfully installed jemoji-0.10.1
1 gem installed
post-installation fixup
patching script interpreter paths in /nix/store/qdvspkkwgaa0rc7cvkc7kxc6329yv1l9-ruby2.4.4-jemoji-0.10.1
building '/nix/store/h376348svbn3714ca5sxjxfq0shk065c-jekyll-3.7.4.drv'...
created 134 symlinks in user environment
/nix/store/m99vkqhkbycxc5fq5cgrm5cz5crzvf6q-gollum-4.1.4
/nix/store/iz8y58k6xm2gy0jxj668nmbd3xwidsns-jekyll-3.7.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

Successfully installed jemoji-0.10.1
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5lvgxdd8bh1yzx9vv57hmbkn7vzm6hsc-ruby2.4.4-jemoji-0.10.1
patching script interpreter paths in /nix/store/5lvgxdd8bh1yzx9vv57hmbkn7vzm6hsc-ruby2.4.4-jemoji-0.10.1
checking for references to /build in /nix/store/5lvgxdd8bh1yzx9vv57hmbkn7vzm6hsc-ruby2.4.4-jemoji-0.10.1...
building '/nix/store/xmmnw79fns5v349m048pvgwamaykqs2h-jekyll-3.7.4.drv'...
created 134 symlinks in user environment
/nix/store/2fl1wliwhy723asm6n84634v95wdgxcm-gollum-4.1.4
/nix/store/1mhl44lkanydr6dms9fhnx1i02aa91cn-jekyll-3.7.4

@primeos primeos merged commit 2677593 into NixOS:release-18.03 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants