Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: fix icon #48208

Merged
merged 1 commit into from Oct 11, 2018
Merged

spotify: fix icon #48208

merged 1 commit into from Oct 11, 2018

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 11, 2018

Motivation for this change

Spotify has broken path to icon in the desktop file. This commit fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Oct 11, 2018

Might be worth cherry-picking into release-18.09, but I don't know what is the policy.

@prusnak prusnak mentioned this pull request Oct 11, 2018
Closed
@fpletz fpletz merged commit 5660ac7 into NixOS:master Oct 11, 2018
@fpletz
Copy link
Member

fpletz commented Oct 11, 2018

Also pushed to 18.09: a8ad1fb. Thanks!

@prusnak prusnak deleted the spotify_fix_icon branch October 11, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @fpletz @GrahamcOfBorg