Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.4.24 -> 0.4.25 #48210

Merged
merged 1 commit into from Oct 14, 2018
Merged

solc: 0.4.24 -> 0.4.25 #48210

merged 1 commit into from Oct 14, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented Oct 11, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib/libevmasm.so
shrinking /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib/libdevcore.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib  /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/bin
patching script interpreter paths in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25
checking for references to /build in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25...
shrinking RPATHs of ELF executables and libraries in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev
checking for references to /build in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/lib/libdevcore.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25
stripping (with command strip and flags -S) in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/lib  /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/bin
patching script interpreter paths in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25
checking for references to /build in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25...
shrinking RPATHs of ELF executables and libraries in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev
checking for references to /build in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev...

@fpletz
Copy link
Member

fpletz commented Oct 11, 2018

Could you please rebase on top of master to remove the merge commits?

@akru
Copy link
Contributor Author

akru commented Oct 12, 2018

@fpletz done

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib/libevmasm.so
shrinking /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib/libdevcore.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/lib  /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25/bin
patching script interpreter paths in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25
checking for references to /build in /nix/store/whmxqibc1xkhg641bmzivira410qbd6m-solc-0.4.25...
shrinking RPATHs of ELF executables and libraries in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev
checking for references to /build in /nix/store/51cvgixb2075a1kd7s4dqwnqm2xdmvk4-solc-0.4.25-dev...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/bin/lllc
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/lib  /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25/bin
patching script interpreter paths in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25
checking for references to /build in /nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25...
shrinking RPATHs of ELF executables and libraries in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev
checking for references to /build in /nix/store/77r3mv7b4q3mn38v3ljb3zw3n633j59z-solc-0.4.25-dev...
/nix/store/mwhh612sqbwa239pgc29zpzyj2386v2q-solc-0.4.25

@Mic92 Mic92 merged commit bb9193b into NixOS:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akru @GrahamcOfBorg @fpletz @Mic92