Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazygit: init at 0.4 #48213

Merged
merged 1 commit into from Oct 11, 2018
Merged

lazygit: init at 0.4 #48213

merged 1 commit into from Oct 11, 2018

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Oct 11, 2018

Motivation for this change

New package. 馃槂

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 11, 2018

Ironically this does not work for nixpkgs yet:

$ ~/git/nixpkgs lazygit
2018/10/11 15:27:32 branch config: invalid merge

other repos work.

@fpletz
Copy link
Member Author

fpletz commented Oct 11, 2018

Weird, it does work for my nixpkgs checkout. 馃樃

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lazygit

Partial log (click to expand)

github.com/jesseduffield/lazygit
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mr2b7rv3i9n2js7lyw6ij5077hv8j7pv-lazygit-0.4-bin
shrinking /nix/store/mr2b7rv3i9n2js7lyw6ij5077hv8j7pv-lazygit-0.4-bin/bin/lazygit
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mr2b7rv3i9n2js7lyw6ij5077hv8j7pv-lazygit-0.4-bin/bin
patching script interpreter paths in /nix/store/mr2b7rv3i9n2js7lyw6ij5077hv8j7pv-lazygit-0.4-bin
checking for references to /build in /nix/store/mr2b7rv3i9n2js7lyw6ij5077hv8j7pv-lazygit-0.4-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: lazygit

Partial log (click to expand)

find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
find: '/nix/store/2c3z364hifsrbvv5hpp4qgdkblm2n7g7-lazygit-0.4': No such file or directory
/nix/store/69b8dxhzlbc6529z79g4p433qkrj6sgc-lazygit-0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lazygit

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin
shrinking /nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin/bin/lazygit
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin/bin
patching script interpreter paths in /nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin
checking for references to /build in /nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/qqisqwqpiz76r1890h0vg9qbahigfwvm-lazygit-0.4-bin

@Mic92 Mic92 merged commit ee79ea0 into NixOS:master Oct 11, 2018
@fpletz fpletz deleted the pkg/lazygit branch October 11, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpletz @Mic92 @GrahamcOfBorg