Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix wording of the overrideScope warning #48216

Merged
merged 1 commit into from Oct 11, 2018
Merged

lib: fix wording of the overrideScope warning #48216

merged 1 commit into from Oct 11, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

@Ericson2314 the current wording of the overrideScope function is wrong. This fixes it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
Copy link
Member

Oops! Thanks.

@Ericson2314 Ericson2314 merged commit 0411195 into NixOS:master Oct 11, 2018
Ericson2314 added a commit that referenced this pull request Oct 11, 2018
@Ericson2314
Merge pull request #48216 from LumiGuide/fix-overrideScope-warning
5fdfc6f 
lib: fix wording of the `overrideScope` warning
(cherry picked from commit 0411195)
@basvandijk
Copy link
Member Author

@Ericson2314 we probably also want to cherry-pick this on release-18.09. Shall I do that?

@Ericson2314
Copy link
Member

I believe that's what 5fdfc6f is?

@basvandijk
Copy link
Member Author

I missed that. Thanks for backporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @Ericson2314 @GrahamcOfBorg