Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem-config: add sassc #48212

Merged
merged 1 commit into from Oct 11, 2018
Merged

gem-config: add sassc #48212

merged 1 commit into from Oct 11, 2018

Conversation

alyssais
Copy link
Member

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -319,6 +319,10 @@ in
dontUseCmakeConfigure = true;
};

sassc = attrs: {
nativeBuildInputs = [ rake ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be an issue if rake was running a different version of ruby?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so – IIRC rake is only used to compile libsass.

@zimbatm zimbatm merged commit da35297 into NixOS:master Oct 11, 2018
@alyssais alyssais deleted the sassc branch November 2, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants