Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yojimbo: init at 1.1 #48214

Merged
merged 3 commits into from Oct 11, 2018
Merged

yojimbo: init at 1.1 #48214

merged 3 commits into from Oct 11, 2018

Conversation

avagordon01
Copy link
Member

@avagordon01 avagordon01 commented Oct 11, 2018 •
edited

Motivation for this change

Upstream the derivation we use for development based on Yojimbo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Oct 11, 2018

@GrahamcOfBorg build yojimbo

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: yojimbo

Partial log (click to expand)

Generated soak.make...
Done (71ms).
==== Building yojimbo (debug_x64) ====
netcode.c
gcc: error: unrecognized command line option '-m64'
gcc: error: unrecognized command line option '-msse2'
make[1]: *** [yojimbo.make:126: obj/x64/Debug/yojimbo/netcode.o] Error 1
make: *** [Makefile:49: yojimbo] Error 2
builder for '/nix/store/z80yc18ih094f7fnag352q5hx98bgnnj-yojimbo.drv' failed with exit code 2
error: build of '/nix/store/z80yc18ih094f7fnag352q5hx98bgnnj-yojimbo.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yojimbo

Partial log (click to expand)



installing
post-installation fixup
/nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo
shrinking RPATHs of ELF executables and libraries in /nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo/lib
patching script interpreter paths in /nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo
checking for references to /build in /nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo...

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: yojimbo

Partial log (click to expand)

Cannot nix-instantiate `yojimbo' because:
error: access to path '/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/default.nix' is forbidden in restricted mode

@fpletz
Copy link
Member

fpletz commented Oct 11, 2018

You've force-pushed my fix-commit away. 😸 If you don't add callPackage for this to pkgs/top-level/all-packages.nix, the expression won't get picked up.

@grahamc
Copy link
Member

grahamc commented Oct 11, 2018

@GrahamcOfBorg build yojimbo

I think I fixed the darwin builder.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: yojimbo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yojimbo

Partial log (click to expand)

/nix/store/djrsy35ab6szmkxi29y5k5926w1kkmww-yojimbo

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: yojimbo

Partial log (click to expand)

finished...
sh: open: command not found
/nix/store/l9c2vhghi2qiwqcva3ynir9gfskq3ldx-yojimbo


installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9c2vhghi2qiwqcva3ynir9gfskq3ldx-yojimbo/lib
patching script interpreter paths in /nix/store/l9c2vhghi2qiwqcva3ynir9gfskq3ldx-yojimbo

@fpletz fpletz merged commit 9d293db into NixOS:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@avagordon01 @fpletz @GrahamcOfBorg @grahamc @Janik-Haag