Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wmfocus: init at 1.0.2 #47662

Merged
merged 2 commits into from Oct 2, 2018
Merged

wmfocus: init at 1.0.2 #47662

merged 2 commits into from Oct 2, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Oct 2, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wmfocus

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2
shrinking /nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2/bin/wmfocus
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2/bin
patching script interpreter paths in /nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2
checking for references to /build in /nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2...
/nix/store/9lzl18a7z36cffkwrikn1pfkxgajx9q1-wmfocus-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wmfocus

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2
shrinking /nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2/bin/wmfocus
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2/bin
patching script interpreter paths in /nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2
checking for references to /build in /nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2...
/nix/store/84anlas096ka2xh4lkjpskcn8yb5l5iy-wmfocus-1.0.2

xeji
xeji reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! The buildInputs needs fixing, LGTM otherwise.

pkgs/applications/window-managers/i3/wmfocus.nix

buildInputs = [python3 pkgconfig glib xorg.libX11 cmake cairo xorg.libX11];
nativeBuildInputs = [libxkbcommon xorg.libxcb xorg.xcbutilkeysyms];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These buildInputs and nativeBuildInputs don't look right. nativeBuildInputs should only contain packages that need to run at buildtime (here: pkgconfig and python3). The rest should be buildInputs. Some of them, like cmake aren't needed at all. I found this to be sufficient to build the package (and it seems to run fine):

nativeBuildInputs = [ python3 pkgconfig ];
buildInputs = [ cairo libxkbcommon xorg.xcbutilkeysyms ];

These buildInputs also match the upstream list of dependencies (minus rust and cargo, which are implied by buildRustPackage).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeji 2255419

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wmfocus

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2
shrinking /nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2/bin/wmfocus
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2/bin
patching script interpreter paths in /nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2
checking for references to /build in /nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2...
/nix/store/bhff4if209zj680a6a31j4w6hx4sj2rx-wmfocus-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wmfocus

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2
shrinking /nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2/bin/wmfocus
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2/bin
patching script interpreter paths in /nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2
checking for references to /build in /nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2...
/nix/store/bxxr0f2c6ii6j4ghc1y5s8a36fzwkamx-wmfocus-1.0.2

@xeji xeji merged commit fbc1fb7 into NixOS:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @xeji