Modified the updated version from 18.1.0 to 18.3.0. Nox review passed.

@jluttine I'm getting a failure with nox-review here :

builder for '/nix/store/ah41qvfvkivwivj3ynq280bmqsv8f40m-python2.7-autobahn-18.8.2.drv' failed with exit code 1
cannot build derivation '/nix/store/xb22ljacjmm4w2ny8a5zb9vrs3n9lwrd-python2.7-magic-wormhole-0.10.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/68ifppjl9jxxhbk1q08rnd1rz426v63z-python3.6-txtorcon-18.3.0.drv', '/nix/store/7bq1lwv4malw0nqa96ldv29zpbv5grk0-python3.6-magic-wormhole-0.10.5.drv', '/nix/store/qwjjhap4plbys0piicvni3png296f85x-python2.7-txtorcon-18.3.0.drv', '/nix/store/rspz6p9dn4iyyjj8173b4rf78znhcz32-Transporter-1.3.3.drv', '/nix/store/xb22ljacjmm4w2ny8a5zb9vrs3n9lwrd-python2.7-magic-wormhole-0.10.5.drv' failed
The invocation of "nix-build -A python27Packages.txtorcon -A python27Packages.magic-wormhole -A python36Packages.magic-wormhole -A transporter -A magic-wormhole -A python36Packages.txtorcon /home/xxx/.nox/nixpkgs" failed

Scrolling up a little I found :

Collecting txaio>=18.8.1 (from autobahn==18.8.2)
creating build/lib/txtorcon
copying txtorcon/web.py -> build/lib/txtorcon
  Could not find a version that satisfies the requirement txaio>=18.8.1 (from autobahn==18.8.2) (from versions: )
copying txtorcon/log.py -> build/lib/txtorcon
copying txtorcon/testutil.py -> build/lib/txtorcon
No matching distribution found for txaio>=18.8.1 (from autobahn==18.8.2)

I'm guessing txaio needs a version bump too?

@c0bw3b Oh, that is weird. I tried again but I'm not getting nox-review failures. I checked out this branch and ran nox-review wip --against HEAD~1. No failures. Could it be because of different systems (I have x86_64 system) or did you rebase/merge the branch somehow?

I used nox-review pr 47670 so it merges the PR on top of master if I'm not mistaken.
It was on a nixos-18.09-small x64 system. I'll retry from a 18.09 demo VM.

EDIT: getting the same error on the VM.

But actually this is not related to your changes...
This is autobahn-18.8.2 failing on Hydra too : Python2 / Python3

So cc @FRidh we're hitting a failure after 7e3a047
It needs txaio>=18.8.1

Ah well there is a PR for that already! --> #48626

My bad for not checking beforehand. So we just need to merge #48626 first otherwise LGTM.

An identical recent pull request #48934 was merged so I'll close this one. Perhaps I shouldn't make this kind of trivial pull requests as they are generated automatically and merged faster. 🙂

Ahh, thanks. Lots of PR's and lack of time cause me not to be able to review all PR's.

Once in a while I do batch upgrades where these kind of changes are introduced. I also asked Ryan to start using the bot again for Python packages, as long as the amount of rebuilds is below 10. The PR's made by the bot are typically very easy to review and thus get my preference. Of course, not everything can be done by the bot.

@FRidh Yes, the bot is really handy. I didn't know about it but I was thinking of the same idea myself. Great that it exists already and is being used! 👍

Would be great, for instance, if the bot informed if nox review failed so then one knows that manual fixes are required. Do you know if it has that feature or what does it do when nox review fails?

Does the automatic bot only update Python packages that are available from PyPI? So Python packages that are only in, for instance, GitHub still require manual updating?

@jluttine please take questions/suggestions to nix-community/nixpkgs-update#83

maybe even open a new issue on the tracker

@FRidh can we go and merge #48626 too?

@FRidh Thanks, I'll check that!

Ahh, thanks. Lots of PR's and lack of time cause me not to be able to review all PR's.

Just want to clarify myself a bit in case I was misinterpreted: I wasn't criticizing you (or anyone) about the delay. I understand it takes time to review and time is a scarce resource and I'm extremely thankful for all the efforts put in this project. That's why I'm not typically "bumping" my pull requests because I know that the reviewers know how to prioritize their own usage of time. I was just saying that now that I learned that there is a bot for doing this kind of pull requests automatically, it probably doesn't make sense for me to make this kind of pull requests manually in the future - which is good. Also, the bot's pull requests are easier to identify as low-effort PRs to review than a PR by some random guy so they most likely are merged faster - which is also good. So sorry if what I said sounded somehow negative, that definitely wasn't the purpose, I wasn't complaining about anything. Thought I'd say this just in case.

As a side comment here: you can find the latest worklogs of this bot here.
There is plenty of packages that it fails to update automatically so PRs for these are welcome.

Also: leaving comments on bot's PR when you notice "things" can help the review process. Plenty of scenarios would need humans double-checking:

• a build input is not needed anymore
• or the new version provides new features but it needs some configure flags or some new build inputs
• patches that should not be applied anymore because it was fixed upstream
• etc...

@jluttine Don't worry, I understood you. I think it would be good to communicate somewhere how we deal with upgrading and automation. What parts are typically dealt with automatically, and if so, how. And how to deal with the failures as pointed out by @c0bw3b.