nixos/networking: Add an option whether to use a local DNS resolver #47669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autodetection is normally fine but e.g. if one runs BIND as an authoritative DNS server without caching or forwarding this can be problematic (the host won't be able to resolve any DNS requests). By introducing an option for this behaviour it is easily possible to explicitly enable or disable the use of a local resolver, which will override the autodetection.
|
@volth Thanks for the comment, I wasn't aware of that PR :)
Yeah, it wasn't flexible at all, it was mainly intended to disable the autodetection. I also probably missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autodetection is normally fine but e.g. if one runs BIND as an
authoritative DNS server without caching or forwarding this can be
problematic (the host won't be able to resolve any DNS requests). By
introducing an option for this behaviour it is easily possible to
explicitly enable or disable the use of a local resolver, which will
override the autodetection.
CC: @regellosigkeitsaxiom @wkennington @vcunat (based on the contributions)
I've tested this change and it works, but there are many alternative implementations (didn't have time to think much about it...). I'm open for suggestions if anyone has a better idea :)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)