Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When you launch CKAN for the very first time (or after clearing the relevant settings from CKAN/GUIConfig.xml), two popups appear to "nag" the user about making certain decisions:
Problem
As shown above, the second popup's buttons are cut off and unreadable if you have this setting turned on in Windows:
Cause
Since AskUserForAutoUpdatesDialog works fine regardless of the above setting, I focused on what was different between the two. There are several differences that seem to affect whether the layout is shown correctly (see next section).
Changes
Now YesNoDialog works more like AskUserForAutoUpdatesDialog:
This seems to fix the problem:
And AskUserForAutoUpdatesDialog works a little bit more like YesNoDialog, for consistency:
Fixes #908.