Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dysinger as a maintainer #47673

Merged
merged 1 commit into from Oct 2, 2018
Merged

added dysinger as a maintainer #47673

merged 1 commit into from Oct 2, 2018

Conversation

dysinger
Copy link
Contributor

@dysinger dysinger commented Oct 2, 2018

Signed-off-by: Tim Dysinger tim@dysinger.net

Motivation for this change

I would like to maintain some nixpkgs and have a PR for 4 more companion apps for 'fldigi' (applications/audio) that are missing from nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dysinger
added dysinger as a maintainer
f030011 
Signed-off-by: Tim Dysinger <tim@dysinger.net>
@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

Usually we do that the other way around when somebody adds a package, but I suppose you have planned to do so in the next days.

@Mic92 Mic92 merged commit 67c86d8 into NixOS:master Oct 2, 2018
@dysinger dysinger deleted the feature/dysinger branch October 2, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dysinger @Mic92 @GrahamcOfBorg