Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jshint: depend on phantomjs2 #47666

Merged
merged 1 commit into from Oct 2, 2018
Merged

jshint: depend on phantomjs2 #47666

merged 1 commit into from Oct 2, 2018

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Oct 2, 2018

Motivation for this change

This fixes #47429. jshint needs phantomjs2 to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

@GrahamcOfBorg build nodePackages.jshint

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.jshint

Partial log (click to expand)

tweetnacl@0.14.5 /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/tweetnacl
ecc-jsbn@0.1.2 /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/ecc-jsbn
jsbn@0.1.1 /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/jsbn
up to date in 1.057s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6
patching script interpreter paths in /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6
/nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/strip-json-comments/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2r6vcc5n711k1nx912hsxnkn24nydxjb-nodejs-8.11.4/bin/node"
checking for references to /build in /nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6...
/nix/store/lp2angd8c6a0ihwc52hxq7r1r6ivy401-node-jshint-2.9.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.jshint

Partial log (click to expand)

tweetnacl@0.14.5 /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/tweetnacl
ecc-jsbn@0.1.2 /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/ecc-jsbn
jsbn@0.1.1 /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/jsbn
up to date in 0.627s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6
patching script interpreter paths in /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6
/nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6/lib/node_modules/jshint/node_modules/strip-json-comments/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/hshlb7ysskab4pa0vqabz50kv9mc1cjd-nodejs-8.11.4/bin/node"
checking for references to /build in /nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6...
/nix/store/dksvgx3pskwlcaz7dcp4jn7nz1g49gva-node-jshint-2.9.6

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nodePackages.jshint

Partial log (click to expand)

  CMakeLists.txt:137 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-qtwebkit-5.212-alpha-01-26-2018.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-qtwebkit-5.212-alpha-01-26-2018.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/4mas5gy08ifjh0cvxkay89fwwkra5xjz-qtwebkit-5.212-alpha-01-26-2018.drv' failed with exit code 1
cannot build derivation '/nix/store/j1jxj6h29l7rvl8ndpbg3xwxa04c8b2y-phantomjs-2.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mkgy4wjv6qxd1mn2irdsqlvi2im0yd3h-node-jshint-2.9.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/mkgy4wjv6qxd1mn2irdsqlvi2im0yd3h-node-jshint-2.9.6.drv' failed

@Mic92 Mic92 merged commit 4c5b6d6 into NixOS:master Oct 2, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

backport: 0f51003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodePackages.jshint fails because it cannot connect to github.com
3 participants
@pmiddend @Mic92 @GrahamcOfBorg