New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4 companion apps for applications/audio/fldigi #47677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add autoreconfHook
to nativeBuildInputs
. It is not really required but regenerating autotools scripts can save us some trouble it put correct paths into the configure files.
Feel free to add a ham directory if you have better insight in this domain. |
ok I will make these changes tonight. Thanks for the feedback. |
https://sourceforge.net/projects/fldigi/ Signed-off-by: Tim Dysinger <tim@dysinger.net>
Signed-off-by: Tim Dysinger <tim@dysinger.net>
Signed-off-by: Tim Dysinger <tim@dysinger.net>
Signed-off-by: Tim Dysinger <tim@dysinger.net>
2ca1806
to
e6fc7df
Compare
Simple changes pushed. |
I will make a separate commit with all the ham-radio-app-maintainers pulled in that moves all the ham apps to their own applications/ham-radio folder |
Motivation for this change
There are many companion apps to 'fldigi' missing from nixpkgs. http://www.w1hkj.com/
This app is not really "audio" but rather is a digital communication platform primarily used for ham radio. The companion apps are external to fldigi but integrate into fldigi in the preferences.
Side comment: nixpkgs really needs a "ham radio" section in the package tree (not unlike applications/science). There are a ton of ham radio apps. Debian even has a dedicated distro/flavor for hams. Some of the existing ham apps are in "misc" and some in "audio" right now on nixpkgs. Just for now I put these fldigi apps in "misc" along side WSJTX because they are definitely not 'audio' apps.
This is my first P/R to nixpkgs so please tell me all things I need to do to correctly get this finished. I see a big checklist below but all I've done is create the packages and use them on my nixos machine for a few days. They work on Nixos and aren't complicated packages. I imagine they'd work anywhere that fldigi works.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)