Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 companion apps for applications/audio/fldigi #47677

Merged
merged 4 commits into from Oct 3, 2018

Conversation

dysinger
Copy link
Contributor

@dysinger dysinger commented Oct 2, 2018

Motivation for this change

There are many companion apps to 'fldigi' missing from nixpkgs. http://www.w1hkj.com/

This app is not really "audio" but rather is a digital communication platform primarily used for ham radio. The companion apps are external to fldigi but integrate into fldigi in the preferences.

2018-10-02-091644_1920x1080_scrot

Side comment: nixpkgs really needs a "ham radio" section in the package tree (not unlike applications/science). There are a ton of ham radio apps. Debian even has a dedicated distro/flavor for hams. Some of the existing ham apps are in "misc" and some in "audio" right now on nixpkgs. Just for now I put these fldigi apps in "misc" along side WSJTX because they are definitely not 'audio' apps.

This is my first P/R to nixpkgs so please tell me all things I need to do to correctly get this finished. I see a big checklist below but all I've done is create the packages and use them on my nixos machine for a few days. They work on Nixos and aren't complicated packages. I imagine they'd work anywhere that fldigi works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ X] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dysinger dysinger changed the title Feature/fldigi Add 4 companion apps for applications/audio/fldigi Oct 2, 2018
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add autoreconfHook to nativeBuildInputs. It is not really required but regenerating autotools scripts can save us some trouble it put correct paths into the configure files.

pkgs/applications/misc/fllog/default.nix Show resolved Hide resolved
pkgs/applications/misc/flmsg/default.nix Show resolved Hide resolved
pkgs/applications/misc/flrig/default.nix Show resolved Hide resolved
pkgs/applications/misc/flwrap/default.nix Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Oct 2, 2018

Feel free to add a ham directory if you have better insight in this domain.

@dysinger
Copy link
Contributor Author

dysinger commented Oct 2, 2018

ok I will make these changes tonight. Thanks for the feedback.

Signed-off-by: Tim Dysinger <tim@dysinger.net>
Signed-off-by: Tim Dysinger <tim@dysinger.net>
Signed-off-by: Tim Dysinger <tim@dysinger.net>
@dysinger
Copy link
Contributor Author

dysinger commented Oct 3, 2018

Simple changes pushed.

@dysinger
Copy link
Contributor Author

dysinger commented Oct 3, 2018

I will make a separate commit with all the ham-radio-app-maintainers pulled in that moves all the ham apps to their own applications/ham-radio folder

@Mic92 Mic92 merged commit f4c6891 into NixOS:master Oct 3, 2018
@dysinger dysinger deleted the feature/fldigi branch October 4, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants