Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document make-channel.nix #47679

Merged
merged 2 commits into from Nov 4, 2018
Merged

Document make-channel.nix #47679

merged 2 commits into from Nov 4, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 2, 2018

Motivation for this change

This documentation was written 11 months ago by @lheckemann during the NixCon 2017 hackathon. I've rebased it so it can be of use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -1,3 +1,7 @@
/* Build a channel tarball. These contain, in addition to the nixpkgs
* expressions themselves, files that indicate the version of nixpkgs
* that they represent. This only seems to be used by Travis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not travis but hydra

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not sure where I got that idea from…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were probably listening to Rae & Christian ;)

@lheckemann
Copy link
Member

Thanks for picking this up! I'd completely forgotten about it…

Besides being incorrect, claims like these tend to stick around
after they become incorrect.
@matthewbauer matthewbauer merged commit d3c2247 into master Nov 4, 2018
@globin globin deleted the docs-make-channel branch November 5, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants