New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor initrd improvements #47665
Minor initrd improvements #47665
Conversation
The improved lspci command shows all available ethernet controllers and their kernel modules. Previously, the user had to provide the slot name of a specific device.
@@ -45,7 +45,8 @@ in | |||
is acquired using DHCP. | |||
|
|||
You should add the module(s) required for your network card to | |||
boot.initrd.availableKernelModules. lspci -v -s <ethernet controller> | |||
boot.initrd.availableKernelModules. | |||
<literal>lspci -v | grep -iA8 'network\|ethernet'</literal> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not used to the doc but shouldn't it be <command>
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github hid the text between < > xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a closer look it seems that NixOS docs and descriptions mostly use <literal>
for complex shell commands:
nixpkgs=$(nix eval --raw '(builtins.fetchTarball { url = https://nixos.org/channels/nixos-unstable/nixexprs.tar.xz; })')
grep -r '<literal>.*|' $nixpkgs
# vs
grep -r '<command>.*|' $nixpkgs
(The formatting is also nicer in the html output 🐱)
I've reverted the change.
f8ded00
to
5382491
Compare
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-december/1711/2 |
@GrahamcOfBorg build nixosTests.boot.luksroot |
Is there any way to get universal keyboard HID support in initrd? |
I think Cherry USB keyboards work with |
In theory that should be usbhid, however some devices are not compliant to the usb keyboard device class. |
nixos/modules/system/boot/kernel.nix
Outdated
@@ -221,7 +221,7 @@ in | |||
"xhci_pci" | |||
"usbhid" | |||
"hid_generic" "hid_lenovo" "hid_apple" "hid_roccat" | |||
"hid_logitech_hidpp" "hid_logitech_dj" | |||
"hid_logitech_hidpp" "hid_logitech_dj" "hid_cherry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's wrong to add a whole bunch of kernel modules to everybody's initrd. Instead nixos-generate-config
should emit the required configuration in hardware-configuration.nix
.
You may want to add hid_cherry
to the initrd of the installation CD, though.
5382491
to
215c91d
Compare
I've removed the extra |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/usb-keyboard-not-recognized-during-boot/14711/3 |
No description provided.