Travis support for better code review #1042
Merged
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Nov 4, 2018
Mic92
force-pushed
the
travis
branch
2 times, most recently
from
995b834 to
7775b06
Compare
|
There is currently I am investigating since it works on my nixpkgs revision: https://travis-ci.com/Mic92/nixops/jobs/156237797#L4428 $ python2 -c 'import boto.ec2' |
This is complementary for github review as it provides instead feedback in the pr interface. Since all it does is building release.nix the maintenance effort should minimal.
Mic92
force-pushed
the
travis
branch
7 times, most recently
from
557fa48 to
0ae2c5b
Compare
Mic92
commented
Nov 10, 2018
Mic92
commented
Nov 10, 2018
|
lgtm |
|
I've enabled travis-ci for this repository. |
|
Is there a special NixOS profile I need to apply on my system in order to run all unittests? Having a higher code coverage would help to get better type suggestions. |
|
Mosts tests are functional, so you need configured backends. |
Merged
|
Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is complementary for github review
as it provides instead feedback in the pr interface.
Since all it does is building release.nix the
maintenance effort should minimal.