Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

humanize: remove platform restriction #49773

Merged
merged 1 commit into from
Nov 7, 2018
Merged

humanize: remove platform restriction #49773

merged 1 commit into from
Nov 7, 2018
+1 −1

Conversation

rdnetto4
Copy link
Contributor

@rdnetto4 rdnetto4 commented Nov 5, 2018

Motivation for this change

This change allows humanize (and by extension, pgcli) to be built/used on OSX.

Things done

Removed platform restriction - it's nonsensical, as we disable execution of tests on line 18 anyway.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@rdnetto4 rdnetto4 requested a review from FRidh as a code owner November 5, 2018 01:23
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2018
7c6f434c
7c6f434c reviewed Nov 5, 2018
View reviewed changes
pkgs/development/python-modules/humanize/default.nix
@@ -22,7 +22,6 @@ buildPythonPackage rec {
homepage = https://github.com/jmoiron/humanize;
license = licenses.mit;
maintainers = with maintainers; [ ];
platforms = platforms.linux; # can only test on linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to put platforms.unix here, not remove the platforms specification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to remove it since humanize only depends on python, and by default buildPythonPackage uses python.meta.platforms

@7c6f434c 7c6f434c merged commit 50602de into NixOS:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@7c6f434c 7c6f434c

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rdnetto4 @marsam @7c6f434c @GrahamcOfBorg