Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvtm-unstable: init at 2018-03-31 #49770

Merged
merged 1 commit into from Nov 21, 2018
Merged

dvtm-unstable: init at 2018-03-31 #49770

merged 1 commit into from Nov 21, 2018

Conversation

luke-clifton
Copy link
Contributor

@luke-clifton luke-clifton commented Nov 5, 2018 •
edited

Motivation for this change

While the project is still seeing commits coming in, there has not been a release in a while.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2018

  1. Please be more specific about large and noticeable fixes or features that are missing in the latest release despite being committed a long time ago — there are projects with rare releases, but by default we consider tracking releases to be the way to go.

Also, is there an upstream issue about a new release?

  1. Is it possible to pick a different commit in master to avoid need for also fetching a fix from an unmerged PR? There is always a risk that this specific commit will end up rebased or something…

  2. Is there something heavily broken in the latest release? Adding a fresh-from-VCS version requires some motivation, but your real motivation is probably enough (but should be documented). Removing latest-release version in favour of some fresh commit requires a very strong reason.

@luke-clifton
Copy link
Contributor Author

  1. dvtm releases are uncommon because the common use-case is to compile from source and apply patches as configuration. Since the last release, there are a few fixes for Darwin, and the patch added as part of this commit fixes a dirty buffer issue which makes it unusable with certain programs.

  2. No. Would you prefer I inlined the patch?

  3. The latest release doesn't work with Darwin (except with the patch I provided last time), and has dirty buffer issues in some cases. I could rejig this and submit a larger patch based of the previous release if that would be more palatable? I just thought that this was more honest...

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2018

I think Darwin support is usually a good enough reason to add an extra version (if there is no stable source URL for that extra patch yet, I guess inlining is a better solution), or to add a small-ish amount of small-ish patches.

As for complete replacement, I want to know @vrthra opinion as the maintainer.

It looks like by the previous upstream standards, there should have been a couple of releases since the last one, so maybe after merging PR-86 you could ask about that…

@lheckemann
Copy link
Member

@GrahamcOfBorg build dvtm

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dvtm

Partial log (click to expand)

installing terminfo description
2 entries written to /nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master/share/terminfo
post-installation fixup
gzipping man pages under /nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master/bin
patching script interpreter paths in /nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master
/nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master/bin/dvtm-pager: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master/bin/dvtm-status: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/2zwzzs2h16yr8h75kqdsvx5gwpgxnfnm-dvtm-master

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dvtm

Partial log (click to expand)

shrinking /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/bin/dvtm-editor
shrinking /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/bin/dvtm
gzipping man pages under /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/bin
patching script interpreter paths in /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master
/nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/bin/dvtm-pager: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master/bin/dvtm-status: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master...
/nix/store/xj4aqx08nchgakgqwv6pkfn7azx78dvi-dvtm-master

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dvtm

Partial log (click to expand)

shrinking /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/bin/dvtm-editor
shrinking /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/bin/dvtm
gzipping man pages under /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/bin
patching script interpreter paths in /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master
/nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/bin/dvtm-pager: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master/bin/dvtm-status: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master...
/nix/store/sv2fy18478wf56vzvyq6c20cjqpx5k1j-dvtm-master

@lheckemann
Copy link
Member

This should be named dvtm-<date> rather than dvtm-master: https://nixos.org/nixpkgs/manual/#sec-package-naming

@luke-clifton luke-clifton force-pushed the dvtm-master branch 2 times, most recently from 37f0367 to 1d12d72 Compare November 14, 2018 23:41
@luke-clifton
Copy link
Contributor Author

Sorry, I rebased to change the commit message to reflect the name change. Additional to your comment, i also switched to using fetchpatch as per the guidelines.

@luke-clifton luke-clifton changed the title dvtm: 0.15 -> master dvtm: 0.15 -> unstable-2018-03-31 Nov 14, 2018
@lheckemann
Copy link
Member

Thanks!

@luke-clifton
Copy link
Contributor Author

Using fetchFromGitHub now.

@lheckemann
Copy link
Member

Just noticed another issue — since the name is changing from dvtm to dvtm-unstable, I think this update won't be caught by nix-env -u. It might make sense to split the unstable dvtm into its own toplevel attr.

@luke-clifton luke-clifton force-pushed the dvtm-master branch 2 times, most recently from 13d5cbd to 9ba0369 Compare November 21, 2018 07:27
@luke-clifton luke-clifton changed the title dvtm: 0.15 -> unstable-2018-03-31 Add dvtm-unstable-2018-03-31 Nov 21, 2018
@luke-clifton
Copy link
Contributor Author

luke-clifton commented Nov 21, 2018 •
edited

Ok, so, I'm just going to leave dvtm-0.15 in there if that is the consensus. I've added dvtm-unstable which can update faster than the release cycle. IF a new release is ever going to happen, people who use nixpkgs.dvtm will get it, but they won't get this update.

@lheckemann
Copy link
Member

lheckemann commented Nov 21, 2018 •
edited

The commit message should be "dvtm-unstable: init at 2018-03-31" (sorry about all the fuss…)

@luke-clifton
Copy link
Contributor Author

Yes, sorry, got my repository standards mixed up.

@luke-clifton luke-clifton changed the title Add dvtm-unstable-2018-03-31 dvtm-unstable: init at 2018-03-31 Nov 21, 2018
@7c6f434c 7c6f434c merged commit b4bfa62 into NixOS:master Nov 21, 2018
@luke-clifton luke-clifton deleted the dvtm-master branch November 22, 2018 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luke-clifton @7c6f434c @lheckemann @GrahamcOfBorg @worldofpeace