Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocal: 2.2.0 -> 2.3.0 #49772

Merged
merged 1 commit into from Nov 6, 2018
Merged

vocal: 2.2.0 -> 2.3.0 #49772

merged 1 commit into from Nov 6, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 5, 2018

Motivation for this change

Vocal has a new release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 5, 2018

@jtojnar
Copy link
Contributor

jtojnar commented Nov 5, 2018

@GrahamcOfBorg build vocal

@worldofpeace
Copy link
Contributor

@jonafato

Can you please apply these changes?

diff --git a/pkgs/applications/audio/vocal/default.nix b/pkgs/applications/audio/vocal/default.nix
index c503c94e4a8..af8b3ac9394 100644
--- a/pkgs/applications/audio/vocal/default.nix
+++ b/pkgs/applications/audio/vocal/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, cmake, ninja, pkgconfig, vala, gtk3, libxml2, granite, webkitgtk, clutter-gtk
+{ stdenv, fetchFromGitHub, cmake, ninja, pkgconfig, vala_0_40, gtk3, libxml2, granite, webkitgtk, clutter-gtk
 , clutter-gst, libunity, libnotify, sqlite, gst_all_1, libsoup, json-glib, gnome3, gobjectIntrospection, wrapGAppsHook }:
 
 stdenv.mkDerivation rec {
@@ -20,13 +20,14 @@ stdenv.mkDerivation rec {
     libxml2
     ninja
     pkgconfig
-    vala
+    vala_0_40 # should be `elementary.vala` when elementary attribute set is merged
     wrapGAppsHook
   ];
 
   buildInputs = with gst_all_1; [
     clutter-gst
     clutter-gtk
+    gnome3.defaultIconTheme # should be `elementary.defaultIconTheme`when elementary attribute set is merged
     gnome3.libgee
     granite
     gst-plugins-base

@jonafato
Copy link
Contributor Author

jonafato commented Nov 5, 2018

@worldofpeace No problem, patch applied.

@worldofpeace
Copy link
Contributor

@jonafato Thanks 👍

@GrahamcOfBorg build vocal

@Mic92
Copy link
Member

Mic92 commented Nov 5, 2018

@GrahamcOfBorg build vocal

@worldofpeace
Copy link
Contributor

Three times a charm 🙏

@Mic92 Mic92 merged commit 19091a5 into NixOS:master Nov 6, 2018
@jonafato jonafato deleted the vocal-2.3.0 branch November 6, 2018 15:01
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vocal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vocal

Partial log (click to expand)

copying path '/nix/store/9m2mlry6nkhy5fvfya8wiahy7ldgdhac-libinput-1.12.2-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/r47sgmndbcn031a6hn0li547manb70ss-libunity-7.1.4' from 'https://cache.nixos.org'...
copying path '/nix/store/zrm6xha8f559c4wvcc9fmqpv71aimg1h-libinput-1.12.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/aw2kcxknrwwmb7al2qmwmjsszwfxama8-v4l-utils-1.14.2' from 'https://cache.nixos.org'...
copying path '/nix/store/vm57dh3pw1wrb9hgj2piynsbc72x8wm9-clutter-1.26.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/z4q7mq6jxb0xcp7yi71qqv470kgl4prl-gst-plugins-good-1.14.2' from 'https://cache.nixos.org'...
copying path '/nix/store/6kdpmlb5kxi0p542cfkbi0wvwahcpxq3-clutter-gst-3.0.26' from 'https://cache.nixos.org'...
copying path '/nix/store/0v73ms6z16dzqgazv4qk52705kma2mai-webkitgtk-2.20.5' from 'https://cache.nixos.org'...
copying path '/nix/store/ky3vvf4gly8i8hq0shx0bf06l4caax67-vocal-2.3.0' from 'https://cache.nixos.org'...
/nix/store/ky3vvf4gly8i8hq0shx0bf06l4caax67-vocal-2.3.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vocal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vocal

Partial log (click to expand)

/nix/store/ky3vvf4gly8i8hq0shx0bf06l4caax67-vocal-2.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vocal

Partial log (click to expand)

copying path '/nix/store/s0zlcddqx9da8h5f81c2jshc34jlyiw3-libtiff-4.0.9-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/rqbqf3l71f8z1m6mlmg9j5hvjnml72nl-pango-1.42.4-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/w0drzap2lsv5rqkan6iwf9l5hw8vkcxk-gdk-pixbuf-2.36.12-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/ahlkvf8mnbsaq4n6hd68dv7f4q5hbzi3-vala-0.40.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/6hg777j5qpl0rzk6a2hgznwpyfnfcmp3-cogl-1.22.2-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/1xkz6nqdp37bx4cs2nhyahl303q166v4-gtk+3-3.22.30-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/vm57dh3pw1wrb9hgj2piynsbc72x8wm9-clutter-1.26.2-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/6kdpmlb5kxi0p542cfkbi0wvwahcpxq3-clutter-gst-3.0.26' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/ky3vvf4gly8i8hq0shx0bf06l4caax67-vocal-2.3.0' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/ky3vvf4gly8i8hq0shx0bf06l4caax67-vocal-2.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vocal

Partial log (click to expand)

cannot build derivation '/nix/store/2dljjg4a97rjvmiaj4bv34g92gzya3zf-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n0wz0d2if77aj1cy0h2wv37cnzqqj38q-librsvg-2.42.4.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/771fi75d6s69nql0528mmcvl701ci01j-gst-plugins-bad-1.14.2.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/p3n1qdyb410zbslqcnzgzggxz4bjn0yk-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cw1xyb6m4hcn87cq7wfs4hwcyzj9vp0q-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5yz1pdfdznp607ba177j83idljkamj5f-adwaita-icon-theme-3.30.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/2h5xzahw9d529lc87i7j2fdgxv234gfa-geoclue-2.4.12.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/w8z9k66dk1n87i1pfnskm57wgd7yl8ab-webkitgtk-2.20.5.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xwwrys6n4s9w31c4xbwkhr9pi2lazpf1-vocal-2.3.0.drv': 10 dependencies couldn't be built
error: build of '/nix/store/xwwrys6n4s9w31c4xbwkhr9pi2lazpf1-vocal-2.3.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: vocal

Partial log (click to expand)

cannot build derivation '/nix/store/2dljjg4a97rjvmiaj4bv34g92gzya3zf-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n0wz0d2if77aj1cy0h2wv37cnzqqj38q-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/771fi75d6s69nql0528mmcvl701ci01j-gst-plugins-bad-1.14.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p3n1qdyb410zbslqcnzgzggxz4bjn0yk-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cw1xyb6m4hcn87cq7wfs4hwcyzj9vp0q-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5yz1pdfdznp607ba177j83idljkamj5f-adwaita-icon-theme-3.30.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2h5xzahw9d529lc87i7j2fdgxv234gfa-geoclue-2.4.12.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w8z9k66dk1n87i1pfnskm57wgd7yl8ab-webkitgtk-2.20.5.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xwwrys6n4s9w31c4xbwkhr9pi2lazpf1-vocal-2.3.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/xwwrys6n4s9w31c4xbwkhr9pi2lazpf1-vocal-2.3.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vocal

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0/bin/com.github.needle-and-thread.vocal
shrinking RPATHs of ELF executables and libraries in /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0
shrinking /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0/bin/.com.github.needle-and-thread.vocal-wrapped
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0/bin
patching script interpreter paths in /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0
checking for references to /build in /nix/store/k97fkza2p4cmskhgkfbwsfsxd76fv0mc-vocal-2.3.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants