Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.1 #49775

Merged
merged 1 commit into from Nov 11, 2018
Merged

vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.1 #49775

merged 1 commit into from Nov 11, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Nov 5, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Nov 6, 2018

@GrahamcOfBorg build vscode-extensions.ms-python.python

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: vscode-extensions.ms-python.python

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: vscode-extensions.ms-python.python

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vscode-extensions.ms-python.python

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@c0deaddict c0deaddict mentioned this pull request Nov 8, 2018
Closed
9 tasks
@jokogr
Copy link
Contributor

jokogr commented Nov 9, 2018

@eadwu since it's not merged yet, could you update it to 2018.10 directly?

@eadwu eadwu force-pushed the vscode-extensions.ms-python.python/2018.9.2 branch from 8987071 to 871d46a Compare November 9, 2018 22:09
@eadwu
Copy link
Member Author

eadwu commented Nov 9, 2018

Done, though I usually check every Sunday, which is when I update my nightly sources.

@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.9.1 -> 2018.9.2 vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.0 Nov 10, 2018
@eadwu eadwu force-pushed the vscode-extensions.ms-python.python/2018.9.2 branch from 871d46a to c4cb982 Compare November 11, 2018 03:00
@eadwu eadwu changed the title vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.0 vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.1 Nov 11, 2018
@srhb srhb merged commit 2aa9d3a into NixOS:master Nov 11, 2018
@eadwu eadwu deleted the vscode-extensions.ms-python.python/2018.9.2 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @srhb @GrahamcOfBorg @jokogr