Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/rngd: do not pass --version flag #49778

Merged
merged 1 commit into from Nov 5, 2018
Merged

nixos/rngd: do not pass --version flag #49778

merged 1 commit into from Nov 5, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Nov 5, 2018

Motivation for this change

At least for me, rngd immediately fails after printing the version number when started with the -v command line flag:

 1  decoysnail  ~  systemctl status rngd.service                                     Mon 05 Nov 2018 10:43:56 AM CET
● rngd.service - Hardware RNG Entropy Gatherer Daemon
   Loaded: loaded (/nix/store/a8sa4nijg2dgbhsmx8335niv3hn8nqwm-unit-rngd.service/rngd.service; linked; vendor preset: >
   Active: failed (Result: exit-code) since Mon 2018-11-05 10:36:54 CET; 8min ago
  Process: 30953 ExecStart=/nix/store/xhd1rkdc13g77c4ydzxyfpma3fgnb9w9-rng-tools-6.6/sbin/rngd -f -v (code=exited, sta>
 Main PID: 30953 (code=exited, status=1/FAILURE)

Nov 05 10:36:54 decoysnail systemd[1]: Started Hardware RNG Entropy Gatherer Daemon.
Nov 05 10:36:54 decoysnail rngd[30953]: rngd 6.6
Nov 05 10:36:54 decoysnail rngd[30953]: Copyright 2001-2004 Jeff Garzik
Nov 05 10:36:54 decoysnail rngd[30953]: Copyright 2017 Neil Horman
Nov 05 10:36:54 decoysnail rngd[30953]: Copyright (c) 2001 by Philipp Rumpf
Nov 05 10:36:54 decoysnail rngd[30953]: This is free software; see the source for copying conditions.  There is NO war>
Nov 05 10:36:54 decoysnail systemd[1]: rngd.service: Main process exited, code=exited, status=1/FAILURE
Nov 05 10:36:54 decoysnail systemd[1]: rngd.service: Failed with result 'exit-code'.

However it works when started without the -v flag:

 3  decoysnail  ~  sudo /nix/store/xhd1rkdc13g77c4ydzxyfpma3fgnb9w9-rng-tools-6.6/sbin/rngd -f

Initalizing available sources

Failed to init entropy source hwrng

Enabling RDRAND rng support

Initalizing entropy source rdrand

cc @JohnAZoidberg @c0bw3b

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Nov 5, 2018 •
edited

Oh yes, sorry the upgrade to version 6.6 broke it.
In earlier versions the -v flag meant --verbose and -V was --version, now both are --version.
They didn't find verbose to be useful and removed it with no replacement.
Ergo: Change looks good.

nhorman/rng-tools@39573df

@Mic92
Copy link
Member

Mic92 commented Nov 5, 2018

@GrahamcOfBorg eval

@gebner
Copy link
Member Author

gebner commented Nov 5, 2018

Evaluation failure seems to be unrelated, master is broken atm.

@gebner gebner merged commit 57dd484 into NixOS:master Nov 5, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 5, 2018

Thanks for this @gebner
I fixed some CLI options in #49350 after v6.6 update but I missed that one...

@c0bw3b c0bw3b mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gebner @JohnAZoidberg @Mic92 @c0bw3b