Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cython: 0.28.5 -> 0.29 #48838

Closed
wants to merge 1 commit into from
Closed

pythonPackages.cython: 0.28.5 -> 0.29 #48838

wants to merge 1 commit into from

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 22, 2018 •
edited

Motivation for this change

A new cython release is out and it breaks sage. So I'm including a sage patch into the upgrade commit.

@FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 22, 2018 20:35
@jtojnar
Copy link
Contributor

jtojnar commented Oct 22, 2018

Duplicate of #48768

@jtojnar jtojnar marked this as a duplicate of #48768 Oct 22, 2018
@timokau
Copy link
Member Author

timokau commented Oct 22, 2018

Thanks for the pointer. I also just noticed that I forgot to take out/investigate an entry to excludedTests. Although I do wonder why FRidh's commit doesn't include it or anything else because for me there was a test failure without that.

@timokau timokau mentioned this pull request Oct 22, 2018
Merged
9 tasks
@FRidh
Copy link
Member

FRidh commented Oct 24, 2018

I've cherry-picked this to python-unstable.

@FRidh FRidh closed this Oct 24, 2018
@timokau
Copy link
Member Author

timokau commented Oct 24, 2018

Thank you. Did you notice the excluded test I mentioned (reimport_from_subinterpreter)? It appears to be a new one.

@timokau timokau deleted the cython-0.29 branch October 24, 2018 09:21
@timokau
Copy link
Member Author

timokau commented Nov 15, 2018

I've been looking into the reimport_from_subinterpreter test. Seems like there is some known issue with PYTHONPATH (cython/cython#2674), but applying that patch doesn't fix it. The error indicates that the subinterpreter cannot find the site module for some reason:

/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/bin/python3.7m -c "import subtest; subtest.run_sub()"
Fatal Python error: initsite: Failed to import the site module
Traceback (most recent call last):
  File "/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages/site.py", line 73, in <module>
    __boot()
  File "/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages/site.py", line 39, in __boot
    raise ImportError("Couldn't find the real 'site' module")
ImportError: Couldn't find the real 'site' module

That is with the upstream patch applied. Pythonpath includes /nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages. Not sure what is going wrong there.

Full PYTHONPATH is:

/build/Cython-0.29/TEST_TMP/3/support/lib.linux-x86_64-3.7:/build/Cython-0.29:/nix/store/vnhyisw9d342c8acq4kllk0m88x7mi92-python3.7-Cython-0.29/lib/python3.7/site-packages:/nix/store/jays6mbk6v026vl37r1534311sby919q-python3.7-pkgconfig-1.4.0/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/bnws4qq4iwrq8cl0qbwy48ynamin9ivj-python3.7-bootstrapped-pip-18.1/lib/python3.7/site-packages:/nix/store/8b7frbkap4gyymka04gq037h79l04541-python3.7-numpy-1.15.3/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/jays6mbk6v026vl37r1534311sby919q-python3.7-pkgconfig-1.4.0/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/bnws4qq4iwrq8cl0qbwy48ynamin9ivj-python3.7-bootstrapped-pip-18.1/lib/python3.7/site-packages:/nix/store/8b7frbkap4gyymka04gq037h79l04541-python3.7-numpy-1.15.3/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/jays6mbk6v026vl37r1534311sby919q-python3.7-pkgconfig-1.4.0/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/bnws4qq4iwrq8cl0qbwy48ynamin9ivj-python3.7-bootstrapped-pip-18.1/lib/python3.7/site-packages:/nix/store/8b7frbkap4gyymka04gq037h79l04541-python3.7-numpy-1.15.3/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/jays6mbk6v026vl37r1534311sby919q-python3.7-pkgconfig-1.4.0/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/bnws4qq4iwrq8cl0qbwy48ynamin9ivj-python3.7-bootstrapped-pip-18.1/lib/python3.7/site-packages:/nix/store/8b7frbkap4gyymka04gq037h79l04541-python3.7-numpy-1.15.3/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/jays6mbk6v026vl37r1534311sby919q-python3.7-pkgconfig-1.4.0/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/sxfigrb467ck11ndssazmx5krdsi2mcb-python3.7-setuptools-40.4.3/lib/python3.7/site-packages:/nix/store/bnws4qq4iwrq8cl0qbwy48ynamin9ivj-python3.7-bootstrapped-pip-18.1/lib/python3.7/site-packages:/nix/store/8b7frbkap4gyymka04gq037h79l04541-python3.7-numpy-1.15.3/lib/python3.7/site-packages:/nix/store/wrsslj1c8xn9r8pw168hdxls4mvmgf4x-python3-3.7.1/lib/python3.7/site-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @jtojnar @FRidh @GrahamcOfBorg