Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gxplugins-lv2: init at 0.5 #48847

Merged
merged 1 commit into from Oct 31, 2018
Merged

gxplugins-lv2: init at 0.5 #48847

merged 1 commit into from Oct 31, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 22, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon changed the title gxplugins: init at 0.5 gxplugins.lv2: init at 0.5 Oct 22, 2018
@nlewo
Copy link
Member

nlewo commented Oct 24, 2018

@GrahamcOfBorg build gxplugins.lv2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gxplugins.lv2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gxplugins.lv2

Partial log (click to expand)

shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_maestro_fz1s.lv2/gx_maestro_fz1s.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_saturate.lv2/gx_saturate_ui.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_saturate.lv2/gx_saturate.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_sd1sim.lv2/gx_sd1sim_ui.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_sd1sim.lv2/gx_sd1sim.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib
patching script interpreter paths in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5
checking for references to /build in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5...
/nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gxplugins.lv2

Partial log (click to expand)

shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_SunFace.lv2/gx_SunFace.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_liquiddrive.lv2/gx_liquiddrive_ui.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_liquiddrive.lv2/gx_liquiddrive.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_uvox.lv2/gx_uvox.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_uvox.lv2/gx_uvox_ui.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib
patching script interpreter paths in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5
checking for references to /build in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5...
/nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5

xeji
xeji suggested changes Oct 30, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -17103,6 +17103,8 @@ with pkgs;

gxmessage = callPackage ../applications/misc/gxmessage { };

gxplugins.lv2 = callPackage ../applications/audio/gxplugins.lv2 { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot have a dot in an attribute name because nix will interpret that as the attibute lv2 of the set gxplugins, which doesn't make sense here (that's why ofborg says zero builds). Please rename consistently to gxplugins-lv2 (or another acceptable name).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback.
I'm happy to make this change, but I'd like to understand your comment.

ofborg says zero builds

Where does it say that?

Should I also rename:

  • sisco.lv2
  • eteroj.lv2
  • ir.lv2
    ?

Copy link
Contributor

@xeji xeji Oct 30, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a top-level set gxplugins only makes sense if you want to group multiple derivations that logically belong together under a common name, like gxplugins.lv2, gxplugins.foo, gxplugins.bar, and you put them in a common gxplugins subdirectory below pkgs. This doesn't seem to be the case here. Some examples in nixpkgs include xorg, gnome3, vimPlugins, gitAndTools, xfce.

Where does it say that?

Usually there's a "Details" link next to the ofborg eval check to a list of all (re)builds caused by the PR. This is missing here because ofborg didn't pick up the new package. But that's not an issue by itself, rather the reason why I noticed your're creating a top-level set. Nevermind.

Should I also rename: sisco.lv2 ...

If these are similar cases, yes. If you think they logically belong together because they're all lv2 plugins (your call), it might make sense to group all these in a top-level lv2-plugins set: lv2-plugins.sisco, lv2-plugins.eteroj, lv2-plugins.gxplugins ... If you want to do that, put them under an a common subdirectory pkgs/applications/audio/lv2-plugins and use recurseIntoAttrs in top-level/all-packages.nix, see the other examples mentioned.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeji Thanks, done.

@magnetophon magnetophon changed the title gxplugins.lv2: init at 0.5 gxplugins-lv2: init at 0.5 Oct 31, 2018
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build gxplugins-lv2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gxplugins-lv2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gxplugins-lv2

Partial log (click to expand)

shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_maestro_fz1s.lv2/gx_maestro_fz1s.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_saturate.lv2/gx_saturate_ui.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_saturate.lv2/gx_saturate.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_sd1sim.lv2/gx_sd1sim_ui.so
shrinking /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib/lv2/gx_sd1sim.lv2/gx_sd1sim.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5/lib
patching script interpreter paths in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5
checking for references to /build in /nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5...
/nix/store/n2lqaqxxn5hfgiid0w53r9qkhjpp3yjf-GxPlugins.lv2-0.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gxplugins-lv2

Partial log (click to expand)

shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_SunFace.lv2/gx_SunFace.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_liquiddrive.lv2/gx_liquiddrive_ui.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_liquiddrive.lv2/gx_liquiddrive.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_uvox.lv2/gx_uvox.so
shrinking /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib/lv2/gx_uvox.lv2/gx_uvox_ui.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5/lib
patching script interpreter paths in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5
checking for references to /build in /nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5...
/nix/store/cg4xxmx1hrw3mgl2nljy2gr85i08cvd8-GxPlugins.lv2-0.5

@xeji xeji merged commit 56b88fb into NixOS:master Oct 31, 2018
@magnetophon magnetophon deleted the gxplugins branch October 31, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @nlewo @GrahamcOfBorg @xeji