Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

particl-core: 0.16.2.0 -> 0.17.0.2 #48836

Merged
merged 2 commits into from Oct 29, 2018
Merged

particl-core: 0.16.2.0 -> 0.17.0.2 #48836

merged 2 commits into from Oct 29, 2018

Conversation

demyanrogozhin
Copy link
Member

Motivation for this change

Update version. Disabled tests and benchmartk to speed up Hydra build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@demyanrogozhin
particl-core: 0.16.2.0 -> 0.17.0.2
4ca86a8 
Update version. Disabled tests and benchmartk to speed up Hydra build.
@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

I agree that running benchmarks during Hydra build doesn't make much sense. But I suggest to keep the tests enabled unless they take so much time that Hydra builds time out. Is that the case here?

Mic92
Mic92 reviewed Oct 23, 2018
View reviewed changes
pkgs/applications/altcoins/particl/particl-core.nix Outdated
configureFlags = [ "--with-boost-libdir=${boost.out}/lib" ];
configureFlags = [
"--disable-bench"
"--enable-tests=no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we run the tests before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this flag only to build tests, and it was never used (not sure about it).
I trust @tecnovert (particl-core developer) to run all tests before publishing release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added doCheck that run tests, also running tests required python3 which was added: 233dad8

@demyanrogozhin
Copy link
Member Author

I agree that running benchmarks during Hydra build doesn't make much sense. But I suggest to keep the tests enabled unless they take so much time that Hydra builds time out. Is that the case here?

Yes, it takes time. I trying to reduce build time as much as possible, because in parallel PR for particl-qt all builds timed out (even on x86_64): #46760

I have no clue how to speed-up compilation or prevent Hydra from timeout...
Kindly appreciate your advice)

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

ofborg timeouts (like you see in #46760) and hydra timeouts are two different things. Most builds that time out on ofborg will succeed on hydra, so usually if a build times out on ofborg we merge anyway and see what happens on hydra. I do not see any recent hydra timeouts for particl-core, so there's no urgent need to speed it up.

But what you can try is enableParallelBuilding = true;. It doesn't work with all packages, but if it does, it speeds up the build by using all available CPU cores (currently this is only built on one core).

@demyanrogozhin
particl-core: Eabled tests and parallel build.
233dad8 
Build now dependent on Python3 and current version of Boost
@demyanrogozhin
Copy link
Member Author

demyanrogozhin commented Oct 27, 2018 •
edited

But what you can try is enableParallelBuilding = true;. It doesn't work with all packages, but if it does, it speeds up the build by using all available CPU cores (currently this is only built on one core).

Didn't know that, thanks for clarification @xeji. Added this tweak and enable tests.

@xeji
Copy link
Contributor

xeji commented Oct 29, 2018

@GrahamcOfBorg build particl-core

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: particl-core

Partial log (click to expand)

shrinking /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/bin/particl-tx
shrinking /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/bin/particl-cli
shrinking /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/bin/particld
shrinking /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/lib/libparticlconsensus.so.0.0.0
gzipping man pages under /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/lib  /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2/bin
patching script interpreter paths in /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2
checking for references to /build in /nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2...
/nix/store/zlp7d7mvwdsz866wd134cyj2q36b87ng-particl-core-0.17.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: particl-core

Partial log (click to expand)

shrinking /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/bin/test_particl
shrinking /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/bin/particld
shrinking /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/bin/particl-tx
shrinking /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/lib/libparticlconsensus.so.0.0.0
gzipping man pages under /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/lib  /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2/bin
patching script interpreter paths in /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2
checking for references to /build in /nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2...
/nix/store/i847275a950zp3i2l5x3vbmcmy4vf9i9-particl-core-0.17.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: particl-core

Partial log (click to expand)

 /nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/mkdir -p '/nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2/lib/pkgconfig'
 /nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -m 644 libparticlconsensus.pc '/nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2/lib/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-particl-core-0.17.0.2.drv-0/particl-core-0.17.0.2'
make[1]: Leaving directory '/private/tmp/nix-build-particl-core-0.17.0.2.drv-0/particl-core-0.17.0.2'
post-installation fixup
gzipping man pages under /nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2/lib  /nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2/bin
patching script interpreter paths in /nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2
/nix/store/95a69dxds7nzkfb8kyivm20a6w0xxdpx-particl-core-0.17.0.2

@xeji xeji merged commit 83a434b into NixOS:master Oct 29, 2018
@demyanrogozhin demyanrogozhin deleted the particl-0.17 branch October 29, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@demyanrogozhin @xeji @GrahamcOfBorg @Mic92