Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.ms-python.python: 2018.8.0 -> 2018.9.1 #48849

Merged
merged 1 commit into from Oct 23, 2018
Merged

vscode-extensions.ms-python.python: 2018.8.0 -> 2018.9.1 #48849

merged 1 commit into from Oct 23, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 23, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

unfree package, build checked locally on x86_64-linux.

@xeji xeji merged commit a53a3bf into NixOS:master Oct 23, 2018
worldofpeace pushed a commit to worldofpeace/nixpkgs that referenced this pull request Dec 14, 2018
@eadwu @worldofpeace
vscode-extensions.ms-python.python: 2018.8.0 -> 2018.9.1 (NixOS#48849)
eb3f66a 
(cherry picked from commit a53a3bf)
@eadwu eadwu deleted the vscode-extensions.ms-python.python/2018.9.1 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @xeji @jokogr @GrahamcOfBorg