Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.ms-vscode.cpptools: update build #48850

Merged

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 23, 2018

Motivation for this change

Updated langComponents and package-events.

Seems to work properly, though includePath warnings are annoying.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 29, 2018

unfree package, build checked locally on x86_64-linux

@xeji xeji merged commit e96d14d into NixOS:master Oct 29, 2018
Mic92 pushed a commit that referenced this pull request Oct 30, 2018
@eadwu eadwu deleted the vscode-extensions.ms-vscode.cpptools/update-build branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants